Bug 191602 – WebKit.ApplicationManifestBasic API test is failing when enabling PSON

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

WebKit.ApplicationManifestBasic API test is failing when enabling PSON:
        /Volumes/Data/WebKit/OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:98
        Value of: [manifest.name isEqualToString:@"A Web Application"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/WebKit/OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:99
        Value of: [manifest.shortName isEqualToString:@"WebApp"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/WebKit/OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:100
        Value of: [manifest.applicationDescription isEqualToString:@"Hello."]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/WebKit/OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:101
        Value of: [manifest.startURL isEqual:[NSURL URLWithString:@"http://example.com/app/start"]]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/WebKit/OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:102
        Value of: [manifest.scope isEqual:[NSURL URLWithString:@"http://example.com/app"]]
          Actual: false
        Expected: true


The issue seems to be that we're process swapping when the client does:
    NSString *htmlString = [NSString stringWithFormat:@"<link rel=\"manifest\" href=\"data:text/plain;charset=utf-8;base64,%@\">", [[NSJSONSerialization dataWithJSONObject:manifestObject options:0 error:nil] base64EncodedStringWithOptions:0]];
    [webView loadHTMLString:htmlString baseURL:[NSURL URLWithString:@"http://example.com/app/index"]];

Could be related to substitute data and it getting dropped if the load swaps to a new process.

[Chris Dumez]

Created attachment 354716 [details]
WIP Patch

[Chris Dumez]

Created attachment 354720 [details]
Patch

[Chris Dumez]

Created attachment 354749 [details]
Patch

[Alex Christensen]

Comment on attachment 354749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354749&action=review

> Source/WebKit/UIProcess/API/APINavigation.h:159
> +    std::optional<SubstituteData> m_substituteData;

Since it is uncommon it might be a little better to use std::unique_ptr so we don't have to always use the memory of the whole structure.

> Source/WebKit/UIProcess/WebNavigationState.h:54
> +    Ref<API::Navigation> createLoadDataNavigation(const IPC::DataReference&, const String& MIMEType, const String& encoding, const String& baseURL, API::Object* userData);

We already have a struct.  Couldn't we just add one parameter here?

[Chris Dumez]

Created attachment 354814 [details]
Patch

[Chris Dumez]

Comment on attachment 354814 [details]
Patch

Clearing flags on attachment: 354814

Committed r238179: <https://trac.webkit.org/changeset/238179>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46064330>