Bug 191624 – WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled:
    TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:473
        Expected equality of these values:
          "PersistentCookieName=CookieValue; SessionCookieName=CookieValue"
          message.UTF8String
            Which is: "PersistentCookieName=CookieValue"

[Chris Dumez]

Created attachment 354770 [details]
Patch

[Alex Christensen]

Comment on attachment 354770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354770&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:482
> +enum ShouldEnableProcessPrewarming { No, Yes };

enum class

[Chris Dumez]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 354770 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354770&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:482
> > +enum ShouldEnableProcessPrewarming { No, Yes };
> 
> enum class

Oh, duh...

[Chris Dumez]

Created attachment 354809 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 354809 [details]
Patch

Clearing flags on attachment: 354809

Committed r238174: <https://trac.webkit.org/changeset/238174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46062884>