Bug 191624 - WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
Summary: WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 191572
  Show dependency tree / graph
 
Reported: 2018-11-13 21:34 PST by Chris Dumez
Modified: 2018-11-14 07:51 PST (History)
7 users (show)

See Also:

Attachments
Patch (6.73 KB, patch)
2018-11-13 21:58 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.74 KB, patch)
2018-11-14 07:32 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-11-13 21:34:32 PST 
TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled:
    TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:473
        Expected equality of these values:
          "PersistentCookieName=CookieValue; SessionCookieName=CookieValue"
          message.UTF8String
            Which is: "PersistentCookieName=CookieValue"
Comment 1 Chris Dumez 2018-11-13 21:58:34 PST 
Created attachment 354770 [details]
Patch
Comment 2 Alex Christensen 2018-11-14 06:07:28 PST 
Comment on attachment 354770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354770&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:482
> +enum ShouldEnableProcessPrewarming { No, Yes };

enum class
Comment 3 Chris Dumez 2018-11-14 07:04:58 PST 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 354770 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354770&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:482
> > +enum ShouldEnableProcessPrewarming { No, Yes };
> 
> enum class

Oh, duh...
Comment 4 Chris Dumez 2018-11-14 07:32:32 PST 
Created attachment 354809 [details]
Patch
Comment 5 WebKit Commit Bot 2018-11-14 07:50:13 PST 
Comment on attachment 354809 [details]
Patch

Clearing flags on attachment: 354809

Committed r238174: <https://trac.webkit.org/changeset/238174>
Comment 6 WebKit Commit Bot 2018-11-14 07:50:15 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-14 07:51:44 PST 
<rdar://problem/46062884>