Bug 164817

Summary: [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, bugs-noreply, cgarcia, mcatanzaro, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=165838
Bug Depends on: 164776, 165837    
Bug Blocks: 153828, 162333, 164587    
Attachments:
Description Flags
patch
none
patch
none
patch alex: review+

Description Philippe Normand 2016-11-16 03:11:45 PST 
Our OpenWebRTC patches are not upstreamed yet. We also need recent GStreamer for the rtpbin bundling support.
Comment 1 Philippe Normand 2016-11-16 03:16:41 PST 
Created attachment 294930 [details]
patch
Comment 2 Alejandro G. Castro 2016-11-16 03:26:17 PST 
Let's do it, I'll let michael or carlos review to make sure it is not bad point.
Comment 3 Philippe Normand 2016-11-16 04:03:09 PST 
Created attachment 294931 [details]
patch
Comment 4 Philippe Normand 2016-11-16 04:26:53 PST 
Comment on attachment 294931 [details]
patch

I'll ditch openwebrtc.modules again and pick the gst patches we need instead of the drastic bump to gst git master.
Comment 5 Philippe Normand 2016-11-16 07:12:19 PST 
Created attachment 294936 [details]
patch
Comment 6 Philippe Normand 2016-11-16 07:46:08 PST 
Dunno what is up with the EWS, the log is too small.
Comment 7 Philippe Normand 2016-11-16 08:17:39 PST 
Cloning into 'gst-plugins-openwebrtc'...
done.
Fetching origin
fatal: reference is not a tree: 9b2199ea970369dbFailed to run "['Tools/Scripts/build-webkit', '--release', '--gtk', '--update-gtk', '--makeargs="-j48"']" exit_code: 1

I suspect the DependenciesGTK/Source/gst-plugins-openwebrtc directory isn't removed beforehand.
Comment 8 Michael Catanzaro 2016-11-16 08:37:55 PST 
Comment on attachment 294936 [details]
patch

EWS is red:

Cloning into 'gst-plugins-openwebrtc'...
done.
Fetching origin
fatal: reference is not a tree: 9b2199ea970369dbFailed to run "['Tools/Scripts/build-webkit', '--release', '--gtk', '--update-gtk', '--makeargs="-j48"']" exit_code: 1
Comment 9 Michael Catanzaro 2016-11-16 08:38:23 PST 
Looks like I didn't read Phil's comments, sorry :P
Comment 10 Philippe Normand 2016-11-16 08:40:50 PST 
I made sure it builds here btw.
Comment 11 Alejandro G. Castro 2016-11-16 22:54:58 PST 
It seems a problem with the git pull of the repository, probably it is not removing the directory and adding a new remote does not work. This could cause the same kind of problems in the bots?
Comment 12 Philippe Normand 2016-11-17 00:10:48 PST 
(In reply to comment #11)
> It seems a problem with the git pull of the repository, probably it is not
> removing the directory and adding a new remote does not work. This could
> cause the same kind of problems in the bots?

I think a clean build is triggered on bots when jhbuild changes, so I think this should be fine.
Comment 13 Philippe Normand 2016-11-21 00:09:31 PST 
Committed r208940: <http://trac.webkit.org/changeset/208940>