Bug 153032

Summary:

Web Inspector: Timelines UI redesign: show content tree outline records in timeline data grids

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

153756, 153387, 153731, 153733, 153760

Bug Blocks:

153036

Attachments:

Description	Flags
[Patch] Proposed Fix	none
[Image] OverviewTimelineView grid	none
[Image] NetworkTimelineView grid	none
[Image] RenderingFrameTimelineView grid	none
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none
[Patch] Proposed Fix	commit-queue: commit-queue-

Description Matt Baker 2016-01-12 12:50:12 PST

* SUMMARY
Show content tree outline records in timeline data grids. The new design eliminates the navigation side bar. Add a new first column with disclosure triangles enabled (except for the Network timeline), and duplicate the data currently shown in the content tree outline.

Comment 1 Radar WebKit Bug Importer 2016-01-14 14:24:07 PST

<rdar://problem/24195317>

Comment 2 Matt Baker 2016-02-05 14:07:22 PST

Created attachment 270768 [details]
[Patch] Proposed Fix

Comment 3 Matt Baker 2016-02-05 14:14:40 PST

Created attachment 270769 [details]
[Image] OverviewTimelineView grid

Graph column w/ TimelineRuler header cell.

Comment 4 Matt Baker 2016-02-05 14:15:51 PST

Created attachment 270770 [details]
[Image] NetworkTimelineView grid

Goto arrow buttons supported in the first column.

Comment 5 Matt Baker 2016-02-05 14:17:07 PST

Created attachment 270771 [details]
[Image] RenderingFrameTimelineView grid

Frames graph stretches across entire view.

Comment 6 Timothy Hatcher 2016-02-05 14:53:08 PST

Comment on attachment 270768 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=270768&action=review

> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:53
>                  eventType: this._record.eventType,

Should this be removed?

> Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:74
> +            return value;

Should this be: return WebInspector.LayoutTimelineRecord.displayNameForEventType(value);

Comment 7 Matt Baker 2016-02-16 11:24:26 PST

(In reply to comment #6)
> Comment on attachment 270768 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270768&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:53
> >                  eventType: this._record.eventType,
> 
> Should this be removed?

Yes, nice catch.

> > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGridNode.js:74
> > +            return value;
> 
> Should this be: return
> WebInspector.LayoutTimelineRecord.displayNameForEventType(value);

The value is formatted once, when creating the cached data. No need to reformat.

Comment 8 Matt Baker 2016-02-16 11:29:37 PST

Created attachment 271457 [details]
[Patch] Proposed Fix

Comment 9 Matt Baker 2016-03-02 15:23:53 PST

Created attachment 272693 [details]
[Patch] Proposed Fix

Comment 10 WebKit Commit Bot 2016-03-02 17:27:28 PST

Comment on attachment 272693 [details]
[Patch] Proposed Fix

Rejecting attachment 272693 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 272693, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
InspectorUI/UserInterface/Views/ScriptTimelineView.js
patching file Source/WebInspectorUI/UserInterface/Views/SourceCodeTimelineTimelineDataGridNode.js
patching file Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js
patching file Source/WebInspectorUI/UserInterface/Views/TimelineView.css
patching file Source/WebInspectorUI/UserInterface/Views/Variables.css

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/913228

Comment 11 Matt Baker 2016-03-02 17:55:02 PST

Created attachment 272715 [details]
[Patch] Proposed Fix

Comment 12 Matt Baker 2016-03-02 19:47:08 PST

Committed r197487: <https://trac.webkit.org/r197487>

Comment 13 WebKit Commit Bot 2016-03-02 20:30:39 PST

Comment on attachment 272715 [details]
[Patch] Proposed Fix

Rejecting attachment 272715 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 272715, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
s).
4 out of 5 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/TimelineDataGridNode.js.rej
patching file Source/WebInspectorUI/UserInterface/Views/TimelineView.css
Hunk #1 succeeded at 36 with fuzz 1 (offset 5 lines).
patching file Source/WebInspectorUI/UserInterface/Views/Variables.css
Hunk #1 succeeded at 51 with fuzz 2 (offset 2 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/913849