Bug 138766 – Move more CSS properties to the new StyleBuilder

• Component: CSS
• Status: RESOLVED FIXED

[Chris Dumez]

Move more CSS properties from DeprecatedStyleBuilder to the new StyleBuilder:
line-height
word-spacing
-webkit-marquee-repetition
-webkit-text-underline-position

[Chris Dumez]

Created attachment 241665 [details]
Patch

[Darin Adler]

Comment on attachment 241665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241665&action=review

> Source/WebCore/css/StyleBuilderConverter.h:438
> +    unsigned t = 0;

How about combinedPosition instead of t as a name for this variable?

> Source/WebCore/css/StyleBuilderConverter.h:440
> +        TextUnderlinePosition t2 = downcast<CSSPrimitiveValue>(currentValue.get());

How about position instead of t2 as a name for this variable?

> Source/WebCore/css/StyleBuilderCustom.h:497
> +static inline CSSToLengthConversionData csstoLengthConversionDataWithTextZoomFactor(StyleResolver& styleResolver)

Should not be marked "static".

> Source/WebCore/css/StyleBuilderCustom.h:505
> +static inline bool convertLineHeight(StyleResolver& styleResolver, const CSSValue& value, Length& length, float multiplier = 1.f)

Should not be marked "static".

> Source/WebCore/css/StyleBuilderCustom.h:548
> +#if ENABLE(IOS_TEXT_AUTOSIZING)
> +inline void applyInheritLineHeight(StyleResolver& styleResolver)

Should add a blank line here.

> Source/WebCore/css/StyleBuilderCustom.h:580
> +}
> +#endif

Should add a blank line here.

[Chris Dumez]

Created attachment 241690 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 241690 [details]
Patch

Rejecting attachment 241690 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
bCore/rendering/style/StyleGridItemData.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/StyleGridItemData.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/StyleBuilder.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/StyleBuilder.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/6263404385796096

[Chris Dumez]

Created attachment 241714 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 241714 [details]
Patch

Clearing flags on attachment: 241714

Committed r176202: <http://trac.webkit.org/changeset/176202>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.