Bug 138983 - Properties in CSSPropertyNames.in should use the new StyleBuilder by default
Summary: Properties in CSSPropertyNames.in should use the new StyleBuilder by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 138766
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-21 15:05 PST by Chris Dumez
Modified: 2014-11-21 17:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (52.68 KB, patch)
2014-11-21 15:34 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-21 15:05:48 PST 
Properties in CSSPropertyNames.in should use the new StyleBuilder by default instead of having to specify [NewStyleBuilder] as option.
Comment 1 Chris Dumez 2014-11-21 15:34:55 PST 
Created attachment 242085 [details]
Patch
Comment 2 Andreas Kling 2014-11-21 16:53:19 PST 
Comment on attachment 242085 [details]
Patch

rs=me, though I think the option should be called DeprecatedStyleBuilder
Comment 3 Chris Dumez 2014-11-21 16:56:11 PST 
The reason I did not use "DeprecatedStyleBuilder" is because some of them are in DeprecatedStyleBuilder, some of them are in StyleResolver.

If I used "DeprecatedStyleBuilder", one might assume all those properties are implemented in DeprecatedStyleBuilder.cpp

In any case, this option is temporary.
Comment 4 Chris Dumez 2014-11-21 17:26:32 PST 
Comment on attachment 242085 [details]
Patch

Clearing flags on attachment: 242085

Committed r176491: <http://trac.webkit.org/changeset/176491>
Comment 5 Chris Dumez 2014-11-21 17:26:36 PST 
All reviewed patches have been landed.  Closing bug.