Bug 138938 – Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder

[Chris Dumez]

Created attachment 241990 [details]
Patch

[Chris Dumez]

Comment on attachment 241990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review

> Source/WebCore/css/StyleBuilderCustom.h:-41
> -namespace StyleBuilderFunctions {

Most of this is just changing the code indentation because I transformed the namespace into a class, and moving the code around to distinguish public and private functions. I will point out which methods are actually new.

> Source/WebCore/css/StyleBuilderCustom.h:445
> +    static void applyInitialTextShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:450
> +    static void applyInheritTextShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:455
> +    static void applyValueTextShadow(StyleResolver& styleResolver, CSSValue& value)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:460
> +    static void applyInitialBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:465
> +    static void applyInheritBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:470
> +    static void applyValueBoxShadow(StyleResolver& styleResolver, CSSValue& value)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:475
> +    static void applyInitialWebkitBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:480
> +    static void applyInheritWebkitBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:485
> +    static void applyValueWebkitBoxShadow(StyleResolver& styleResolver, CSSValue& value)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:500
> +    static void applyTextOrBoxShadowValue(StyleResolver& styleResolver, CSSValue& value)

This is new.

[Sam Weinig]

Comment on attachment 241990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review

> Source/WebCore/css/StyleBuilderCustom.h:504
> +            styleResolver.style()->setTextShadow(nullptr);

What about box shadow here?

[Chris Dumez]

Created attachment 242345 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242345 [details]
Patch

Clearing flags on attachment: 242345

Committed r176621: <http://trac.webkit.org/changeset/176621>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.