Bug 138938 - Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder
Summary: Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 138766 138999
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-20 15:10 PST by Chris Dumez
Modified: 2014-12-01 18:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (64.22 KB, patch)
2014-11-20 15:18 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (12.55 KB, patch)
2014-12-01 14:39 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-20 15:10:39 PST
Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder
Comment 1 Chris Dumez 2014-11-20 15:18:00 PST
Created attachment 241990 [details]
Patch
Comment 2 Chris Dumez 2014-11-20 16:13:34 PST
Comment on attachment 241990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review

> Source/WebCore/css/StyleBuilderCustom.h:-41
> -namespace StyleBuilderFunctions {

Most of this is just changing the code indentation because I transformed the namespace into a class, and moving the code around to distinguish public and private functions. I will point out which methods are actually new.

> Source/WebCore/css/StyleBuilderCustom.h:445
> +    static void applyInitialTextShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:450
> +    static void applyInheritTextShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:455
> +    static void applyValueTextShadow(StyleResolver& styleResolver, CSSValue& value)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:460
> +    static void applyInitialBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:465
> +    static void applyInheritBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:470
> +    static void applyValueBoxShadow(StyleResolver& styleResolver, CSSValue& value)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:475
> +    static void applyInitialWebkitBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:480
> +    static void applyInheritWebkitBoxShadow(StyleResolver& styleResolver)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:485
> +    static void applyValueWebkitBoxShadow(StyleResolver& styleResolver, CSSValue& value)

This is new.

> Source/WebCore/css/StyleBuilderCustom.h:500
> +    static void applyTextOrBoxShadowValue(StyleResolver& styleResolver, CSSValue& value)

This is new.
Comment 3 Sam Weinig 2014-11-20 20:39:01 PST
Comment on attachment 241990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241990&action=review

> Source/WebCore/css/StyleBuilderCustom.h:504
> +            styleResolver.style()->setTextShadow(nullptr);

What about box shadow here?
Comment 4 Chris Dumez 2014-12-01 14:39:05 PST
Created attachment 242345 [details]
Patch
Comment 5 WebKit Commit Bot 2014-12-01 18:16:30 PST
Comment on attachment 242345 [details]
Patch

Clearing flags on attachment: 242345

Committed r176621: <http://trac.webkit.org/changeset/176621>
Comment 6 WebKit Commit Bot 2014-12-01 18:16:37 PST
All reviewed patches have been landed.  Closing bug.