Bug 138999 - Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle
Summary: Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 138766
Blocks: 138938
  Show dependency tree / graph
 
Reported: 2014-11-21 21:28 PST by Chris Dumez
Modified: 2014-12-01 10:42 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.17 KB, patch)
2014-11-21 21:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (23.42 KB, patch)
2014-12-01 09:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-11-21 21:28:39 PST 
Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle. This is needed because some of the StyleBuilderCustom functions need to access RenderStyle's private API.
DeprecatedStyleBuilder and StyleResolver (where the style builder code is coming from) are already marked as friend of RenderStyle.
Comment 1 Chris Dumez 2014-11-21 21:53:27 PST 
Created attachment 242109 [details]
Patch
Comment 2 WebKit Commit Bot 2014-11-22 18:26:58 PST 
Comment on attachment 242109 [details]
Patch

Rejecting attachment 242109 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242109, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
t.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114.
error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/6106075640102912
Comment 3 Chris Dumez 2014-12-01 09:45:28 PST 
Created attachment 242316 [details]
Patch
Comment 4 WebKit Commit Bot 2014-12-01 10:42:28 PST 
Comment on attachment 242316 [details]
Patch

Clearing flags on attachment: 242316

Committed r176593: <http://trac.webkit.org/changeset/176593>
Comment 5 WebKit Commit Bot 2014-12-01 10:42:32 PST 
All reviewed patches have been landed.  Closing bug.