Bug 138999 – Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle. This is needed because some of the StyleBuilderCustom functions need to access RenderStyle's private API.
DeprecatedStyleBuilder and StyleResolver (where the style builder code is coming from) are already marked as friend of RenderStyle.

[Chris Dumez]

Created attachment 242109 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242109 [details]
Patch

Rejecting attachment 242109 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242109, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
t.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for '[e-mail]': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114.
error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/6106075640102912

[Chris Dumez]

Created attachment 242316 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242316 [details]
Patch

Clearing flags on attachment: 242316

Committed r176593: <http://trac.webkit.org/changeset/176593>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.