Bug 135290

Summary:	Rename FontData and friends to better names
Product:	WebKit	Reporter:	Myles C. Maxfield <mmaxfield>
Component:	Layout and Rendering	Assignee:	Myles C. Maxfield <mmaxfield>
Status:	NEW ---
Severity:	Normal	CC:	darin, koivisto
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	140124, 140442, 140496
Bug Blocks:

Description Myles C. Maxfield 2014-07-25 08:35:59 PDT

Font represents a CSS font, not a platform font. A FontData is either one or a collection of SimpleFontData objects. SimpleFontData has a function called fontData() which returns AdditionalFontData and a member variable of type DerivedFontData. These names are confusing.

Comment 1 Antti Koivisto 2015-01-06 03:48:52 PST

Maybe something like:

Font -> CompositeFont 
SimpleFontData -> Font
SegmentedFontData -> SegmentedFont
FontData -> FontBase (eliminating the inheritance here would be good)
AdditionalFontData -> SVGFontCallback (no need to be coy)
SimpleFontData::fontData() -> SimpleFontData::svgFontCallback()