Bug 126236

Summary:	Web Inspector: Clean up dead/useless code
Product:	WebKit	Reporter:	Seokju Kwon <seokju>
Component:	Web Inspector	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bburg, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	All
OS:	All
Bug Depends on:	126149, 126312, 126369, 126374, 126377, 126607, 126614, 126630
Bug Blocks:

Description Seokju Kwon 2013-12-25 15:43:21 PST

Master bug.
There are so many dead codes in WebInspectorUI.

Comment 1 Radar WebKit Bug Importer 2013-12-25 15:43:31 PST

<rdar://problem/15725242>

Comment 2 Seokju Kwon 2014-01-07 21:50:47 PST

I will try to get rid of unused overriding protocols.
Any opinions welcome on this. And I will file bugs if there is no objection.

-Page.setGeolocationOverride
-Page.clearGeolocationOverride
-Page.canOverrideGeolocation
-Page.setDeviceOrientationOverride
-Page.clearDeviceOrientationOverride
-Page.canOverrideGeolocation
-Network.setUserAgentOverride

Comment 3 Timothy Hatcher 2014-01-07 21:58:48 PST

(In reply to comment #2)
> I will try to get rid of unused overriding protocols.
> Any opinions welcome on this. And I will file bugs if there is no objection.
> 
> -Page.setGeolocationOverride
> -Page.clearGeolocationOverride
> -Page.canOverrideGeolocation
> -Page.setDeviceOrientationOverride
> -Page.clearDeviceOrientationOverride
> -Page.canOverrideGeolocation
> -Network.setUserAgentOverride

Those are all fine to remove.

Comment 4 Seokju Kwon 2014-01-10 00:52:59 PST

Another attempt to remove protocols. Please let me know what you think.

Page.setShowPaintRects
Page.canShowDebugBorders
Page.setShowDebugBorders
Page.canShowFPSCounter
Page.setShowFPSCounter
Page.canContinuouslyPaint
PAge.setContinuousPaintingEnabled

Comment 5 Timothy Hatcher 2014-01-10 05:46:53 PST

(In reply to comment #4)
> Another attempt to remove protocols. Please let me know what you think.
> 
> Page.setShowPaintRects
> Page.canShowDebugBorders
> Page.setShowDebugBorders
> Page.canShowFPSCounter
> Page.setShowFPSCounter
> Page.canContinuouslyPaint
> PAge.setContinuousPaintingEnabled

Lets keep setShowPaintRects.

Comment 6 Joseph Pecoraro 2016-12-14 10:34:11 PST

I am pretty sure these have all been deleted by now.

Comment 7 BJ Burg 2016-12-14 11:42:11 PST

Thanks Joe!