Bug 126236
| Summary: | Web Inspector: Clean up dead/useless code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Seokju Kwon <seokju> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, inspector-bugzilla-changes, joepeck, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 126149, 126312, 126369, 126374, 126377, 126607, 126614, 126630 | ||
| Bug Blocks: | |||
Seokju Kwon
Master bug.
There are so many dead codes in WebInspectorUI.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/15725242>
Seokju Kwon
I will try to get rid of unused overriding protocols.
Any opinions welcome on this. And I will file bugs if there is no objection.
-Page.setGeolocationOverride
-Page.clearGeolocationOverride
-Page.canOverrideGeolocation
-Page.setDeviceOrientationOverride
-Page.clearDeviceOrientationOverride
-Page.canOverrideGeolocation
-Network.setUserAgentOverride
Timothy Hatcher
(In reply to comment #2)
> I will try to get rid of unused overriding protocols.
> Any opinions welcome on this. And I will file bugs if there is no objection.
>
> -Page.setGeolocationOverride
> -Page.clearGeolocationOverride
> -Page.canOverrideGeolocation
> -Page.setDeviceOrientationOverride
> -Page.clearDeviceOrientationOverride
> -Page.canOverrideGeolocation
> -Network.setUserAgentOverride
Those are all fine to remove.
Seokju Kwon
Another attempt to remove protocols. Please let me know what you think.
Page.setShowPaintRects
Page.canShowDebugBorders
Page.setShowDebugBorders
Page.canShowFPSCounter
Page.setShowFPSCounter
Page.canContinuouslyPaint
PAge.setContinuousPaintingEnabled
Timothy Hatcher
(In reply to comment #4)
> Another attempt to remove protocols. Please let me know what you think.
>
> Page.setShowPaintRects
> Page.canShowDebugBorders
> Page.setShowDebugBorders
> Page.canShowFPSCounter
> Page.setShowFPSCounter
> Page.canContinuouslyPaint
> PAge.setContinuousPaintingEnabled
Lets keep setShowPaintRects.
Joseph Pecoraro
I am pretty sure these have all been deleted by now.
Blaze Burg
Thanks Joe!