Bug 122318

Summary: FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and stack layout
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 113647, 116189, 122487, 122739, 123219    
Bug Blocks: 112840    
Attachments:
Description Flags
LLVM trunk patch to support new webkit intrinsics.
none
rebased LLVM patch
none
the patch
none
the patch ggaren: review+

Description Filip Pizlo 2013-10-03 22:00:28 PDT 
Patch and further description forthcoming.
Comment 1 Andrew Trick 2013-10-04 11:12:28 PDT 
Created attachment 213378 [details]
LLVM trunk patch to support new webkit intrinsics.
Comment 2 Filip Pizlo 2013-10-07 11:39:40 PDT 
Created attachment 213605 [details]
rebased LLVM patch

Just rebasing.
Comment 3 Mark Rowe (bdash) 2013-10-09 02:37:00 PDT 
Probably worth using the correct spellings of JavaScript and WebKit in the comments within the LLVM patch. You've used "Java Script", "javascript" and "webkit" in various places.
Comment 4 Filip Pizlo 2013-10-23 13:46:53 PDT 
OK, it looks like we have GetById IC's and OSR exits working with stackmap/patchpoint.  So, as far as I can tell, those intrinsics Work As Advertised.  So lets get 'em landed in LLVM trunk!
Comment 5 Filip Pizlo 2013-11-02 20:18:03 PDT 
Created attachment 215844 [details]
the patch
Comment 6 Filip Pizlo 2013-11-02 20:54:41 PDT 
Created attachment 215845 [details]
the patch
Comment 7 Geoffrey Garen 2013-11-03 10:18:19 PST 
Comment on attachment 215845 [details]
the patch

r=me
Comment 8 Filip Pizlo 2013-11-03 10:22:56 PST 
Landed in http://trac.webkit.org/changeset/158535