Bug 119756

Summary: [CSS Grid Layout] Handle 'span' positions during layout
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kling, kondapallykalyan, rniwa, svillar
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 118051, 119801    
Bug Blocks: 60731, 103314, 119540    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Sergio Villar Senin
Reported 2013-08-13 10:25:30 PDT
In bug 118051 we added support for the 'span' keyword at parser level. This change effectively uses it to perform the final layout of the grid items. This has been already implemented in Blink. We should probably merge: r149133 Properly handle 'span' position during layout This change plumbs the final bits so that we now recognize 'span' positions and resolve them accordingly.
Attachments
Patch (14.23 KB, patch)
2013-08-28 04:15 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (14.12 KB, patch)
2013-08-28 09:15 PDT, Sergio Villar Senin 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-08-28 04:15:44 PDT
Created attachment 209864 [details] Patch
Sergio Villar Senin
Comment 2 2013-08-28 09:15:32 PDT
Created attachment 209894 [details] Patch
Sergio Villar Senin
Comment 3 2013-08-28 09:48:09 PDT
Committed r154753: <http://trac.webkit.org/changeset/154753>
Sergio Villar Senin
Comment 4 2013-11-06 08:40:08 PST
*** Bug 115404 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.