Bug 118716
| Summary: | [EFL][WK2] Relevant test classes should be redefined by inheriting from EWK2UnitTestBase as per each test file | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Donggwan Kim <donggwan.kim> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | gyuyoung.kim |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Bug Depends on: | 118717, 118721, 118726, 118762, 118763, 118766, 118767, 118769, 118771, 118772, 118773, 118775, 118777, 118779, 118780 | ||
| Bug Blocks: | |||
Donggwan Kim
All the test files use EWK2UnitTestBase only.
There are many methods and variables defined in each test file as static.
It should be defined as relevant test class specific to each test file for more readability like below.
class EWK2FooTest : public EWK2UnitTestBase {
public:
void foo();
};
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Donggwan Kim
I uploaded the patch as sample. (https://bugs.webkit.org/show_bug.cgi?id=118717)
If this approach is accepted by a reviewer, i will modify all other test cases as well.
Donggwan Kim
All the dependent patches was fixed and closed.