Summary: | Invisible Operators should not add space | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bfulgham, cfleizach, commit-queue, dbarton, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, mrobinson | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
URL: | http://www.w3.org/TR/MathML/chapter3.html#presm.invisibleops | ||||||||||||||
Bug Depends on: | 99620, 115787, 124838 | ||||||||||||||
Bug Blocks: | 84019, 115789, 122297, 128907 | ||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2013-05-08 02:49:50 PDT
A Chromium bug was reported last January: http://code.google.com/p/chromium/issues/detail?id=169753 Created attachment 225243 [details]
Patch
Created attachment 225996 [details]
Patch
Just refreshing the patch.
Comment on attachment 225996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=225996&action=review is this ready for r? > Source/WebCore/rendering/mathml/RenderMathMLOperator.h:91 > + bool isInvisibleOperator() { return 0x2061 <= m_operator && m_operator <= 0x2064; } this can be const (In reply to comment #4) > (From update of attachment 225996 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=225996&action=review > > is this ready for r? I don't think the patch will change much, but this applies on top of the patch of bug 115787 which itself applies on top of bug 124838... Did you find anything about how to make the accessibility test pass after the patch for bug 124838? Created attachment 226402 [details]
Patch + 115787 for testing
Created attachment 226411 [details]
Patch
This applies on top of 115787.
Comment on attachment 226411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=226411&action=review > Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1306 > + // In some fonts, glyphs for invisible operators have nonzero width. Consequently, we substract that width here to avoid wide gaps. substract -> subtract Committed r165464: <http://trac.webkit.org/changeset/165464> Interestingly, <p>_⁢_</p> does not produce space on Gecko but it does on WebKit. According to Khaled Hosny, HarfBuzz handles these characters specifically: https://bugzilla.mozilla.org/show_bug.cgi?id=522393#c43 |