Bug 113199

Summary: [Qt] Enable sub-pixel layout
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Layout and RenderingAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, hausmann, jesus, noam, ossy, vestbo, webkit-ews, webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 113301, 115304, 116812    
Bug Blocks: 85532, 114667    
Attachments:
Description Flags
Subpixel underline
none
Patch
none
Patch
none
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2013-03-25 07:33:16 PDT
This is meta bug for tracking enabling sub-pixel layout on the Qt platform.
Attachments
Subpixel underline (8.75 KB, image/png)
2013-03-25 07:45 PDT, Allan Sandfeld Jensen 		no flags
Details
Patch (2.86 KB, patch)
2013-03-25 09:15 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2013-03-25 09:51 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.35 KB, patch)
2013-03-26 06:05 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.11 KB, patch)
2013-04-05 02:48 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-03-25 07:37:21 PDT
I have been experimenting with SUBPIXEL_LAYOUT in order to determine if we should enable it for Qt 5.1 while we are already causing baseline changes due to font rendering. There does however seem to be a few regression. In particular the text underline seems to get placed a pixel to high. I suggest tracking the progress Mac is having in fixing the regressions in subpixel layout, though we could also bite the bullet and share the experience with them. Open Mac bugs related to enabling subpixel_layout: bug 101220, bug 111280, bug 112227 and bug 101848.
Allan Sandfeld Jensen
Comment 2 2013-03-25 07:45:22 PDT
Created attachment 194855 [details] Subpixel underline An example of the most visible subpixel layout regression. Note the underline under the bug nummer is touching the text, and that the underline under | is intersecting the line instead of going under it.
Allan Sandfeld Jensen
Comment 3 2013-03-25 09:15:16 PDT
Created attachment 194869 [details] Patch
Allan Sandfeld Jensen
Comment 4 2013-03-25 09:16:09 PDT
(In reply to comment #2) > Created an attachment (id=194855) [details] > Subpixel underline > > An example of the most visible subpixel layout regression. Note the underline under the bug nummer is touching the text, and that the underline under | is intersecting the line instead of going under it. Turned out to be unrelated to the otherwise similar Mac problem. We were just rounding poorly in GraphicsContext::drawLine.
Early Warning System Bot
Comment 5 2013-03-25 09:34:52 PDT
Comment on attachment 194869 [details] Patch Attachment 194869 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17321042
Early Warning System Bot
Comment 6 2013-03-25 09:38:24 PDT
Comment on attachment 194869 [details] Patch Attachment 194869 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17297292
Allan Sandfeld Jensen
Comment 7 2013-03-25 09:51:20 PDT
Created attachment 194873 [details] Patch Fix wrong comment style
Allan Sandfeld Jensen
Comment 8 2013-03-26 06:05:24 PDT
Created attachment 195071 [details] Patch Now only with the enabling part.
Allan Sandfeld Jensen
Comment 9 2013-03-26 08:51:00 PDT
I have run all enabled layout tests after rebaselining for 5.1 before subpixel_layout. It "only" affects around 1000 baselines. I have checked all that had an image-diff of more than 2% and they were all still correct.
Allan Sandfeld Jensen
Comment 10 2013-04-05 02:48:11 PDT
Created attachment 196605 [details] Patch
Jocelyn Turcotte
Comment 11 2013-04-15 06:41:24 PDT
Comment on attachment 196605 [details] Patch r=me, please just make sure to synchronize with Adam and Zoltan to land it.
Allan Sandfeld Jensen
Comment 12 2013-04-17 01:56:00 PDT
Comment on attachment 196605 [details] Patch Clearing flags on attachment: 196605 Committed r148594: <http://trac.webkit.org/changeset/148594>
Allan Sandfeld Jensen
Comment 13 2013-04-17 01:56:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.