| Summary: | [Qt] Enable sub-pixel layout | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | abecsi, hausmann, jesus, noam, ossy, vestbo, webkit-ews, webkit.review.bot, zarvai | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 113301, 115304, 116812 | ||||||||||||||
| Bug Blocks: | 85532, 114667 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Allan Sandfeld Jensen
2013-03-25 07:33:16 PDT
I have been experimenting with SUBPIXEL_LAYOUT in order to determine if we should enable it for Qt 5.1 while we are already causing baseline changes due to font rendering. There does however seem to be a few regression. In particular the text underline seems to get placed a pixel to high. I suggest tracking the progress Mac is having in fixing the regressions in subpixel layout, though we could also bite the bullet and share the experience with them. Open Mac bugs related to enabling subpixel_layout: bug 101220, bug 111280, bug 112227 and bug 101848. Created attachment 194855 [details]
Subpixel underline
An example of the most visible subpixel layout regression. Note the underline under the bug nummer is touching the text, and that the underline under | is intersecting the line instead of going under it.
Created attachment 194869 [details]
Patch
(In reply to comment #2) > Created an attachment (id=194855) [details] > Subpixel underline > > An example of the most visible subpixel layout regression. Note the underline under the bug nummer is touching the text, and that the underline under | is intersecting the line instead of going under it. Turned out to be unrelated to the otherwise similar Mac problem. We were just rounding poorly in GraphicsContext::drawLine. Comment on attachment 194869 [details] Patch Attachment 194869 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17321042 Comment on attachment 194869 [details] Patch Attachment 194869 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17297292 Created attachment 194873 [details]
Patch
Fix wrong comment style
Created attachment 195071 [details]
Patch
Now only with the enabling part.
I have run all enabled layout tests after rebaselining for 5.1 before subpixel_layout. It "only" affects around 1000 baselines. I have checked all that had an image-diff of more than 2% and they were all still correct. Created attachment 196605 [details]
Patch
Comment on attachment 196605 [details]
Patch
r=me, please just make sure to synchronize with Adam and Zoltan to land it.
Comment on attachment 196605 [details] Patch Clearing flags on attachment: 196605 Committed r148594: <http://trac.webkit.org/changeset/148594> All reviewed patches have been landed. Closing bug. |