Bug 113301 - [Qt] Poor rounding in GraphicsContext::drawLineForText
Summary: [Qt] Poor rounding in GraphicsContext::drawLineForText
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
Depends on:
Blocks: 113199
  Show dependency treegraph
Reported: 2013-03-26 06:02 PDT by Allan Sandfeld Jensen
Modified: 2013-03-26 06:53 PDT (History)
3 users (show)

See Also:

Patch (1.56 KB, patch)
2013-03-26 06:03 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-03-26 06:02:08 PDT
We truncate the position of the line in GraphicsContext::drawLineForText, this gives correct results as long as the coordinates coming in are integer. If we enable SUBPIXEL_LAYOUT however the positions coming in will often be fractions of pixels leading to bad rounding.
Comment 1 Allan Sandfeld Jensen 2013-03-26 06:03:51 PDT
Created attachment 195070 [details]
Comment 2 WebKit Review Bot 2013-03-26 06:53:54 PDT
Comment on attachment 195070 [details]

Clearing flags on attachment: 195070

Committed r146878: <http://trac.webkit.org/changeset/146878>
Comment 3 WebKit Review Bot 2013-03-26 06:53:57 PDT
All reviewed patches have been landed.  Closing bug.