WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114667
[Qt] Landing new expected results after enable sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=114667
Summary
[Qt] Landing new expected results after enable sub-pixel layout
Zoltan Arvai
Reported
2013-04-16 00:33:34 PDT
After landing sub-pixel layout enabler about 1030 test expected needs to be updated. New expected generation currently is in progress...
Attachments
update-qt-expected.patch
(
deleted
)
2013-04-16 01:51 PDT
,
Zoltan Arvai
no flags
Details
Formatted Diff
Diff
update-qt-wk2-expected.patch
(197.14 KB, patch)
2013-04-16 06:05 PDT
,
Zoltan Arvai
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zoltan Arvai
Comment 1
2013-04-16 00:40:09 PDT
A three step update seems to be optimal: 1) updating Qt (WK1) text expected results 2) updating Qt WK2 text expected results if necessary 3) updating png expected results generated with pixelbot environment I'll attach to this bug the updates shortly.
Zoltan Arvai
Comment 2
2013-04-16 01:51:55 PDT
Created
attachment 198277
[details]
update-qt-expected.patch First step: qt (wk1) text expected updates.
Zoltan Arvai
Comment 3
2013-04-16 06:05:29 PDT
Created
attachment 198321
[details]
update-qt-wk2-expected.patch Second step: qt wk2 text expected updates. Some css3 test crashing with: crash log for WebProcess (pid <unknown>): STDOUT: <empty> STDERR: [xcb] Too much data requested from _XRead STDERR: [xcb] This is most likely caused by a broken X extension library STDERR: [xcb] Aborting, sorry about that. STDERR: QtWebProcess: ../../src/xcb_io.c:735: _XRead: Assertion `!xcb_xlib_too_much_data_requested' failed.
Zoltan Arvai
Comment 4
2013-04-16 08:11:46 PDT
Step 3: png update is also ready. It's 25MB so maybe better if i not upload it to bugzilla :-)
Zoltan Arvai
Comment 5
2013-04-17 02:40:46 PDT
First patch (Qt WK1) landend in
http://trac.webkit.org/changeset/148596
Waiting for layout test results after rebaselining and of it is ok than landing second one.
Zoltan Arvai
Comment 6
2013-04-18 08:32:26 PDT
Updated expected results landed in
http://trac.webkit.org/changeset/148596
, qt (wk1)
http://trac.webkit.org/changeset/148599
, Cleaning up unneeded expecteds
http://trac.webkit.org/changeset/148607
, Cleaning up qt-5.0-wk2
http://trac.webkit.org/changeset/148612
, Updating qt png expected results
http://trac.webkit.org/changeset/148661
, Updating qt-5.0-wk2 png expected results
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug