Bug 103723 – [EFL] Volume control unable to show when preload="none" and src file is remote

• Component: WebKit EFL
• Status: RESOLVED DUPLICATE

[Halton Huo]

Build EFL port on trunk@136087 and run MiniBrowser to access http://www.webmfiles.org/demo-files/, the volume control unable to show whatever preview and playing.

The related html code is:
<video width="560" height="320" controls="controls" preload="none"><source src="http://video.webmfiles.org/big-buck-bunny_trailer.webm" type="video/webm"></video>

I dump the page locally and do changes
* remove preload="none", then bug disappear
* download webm file to local and change src point to local, the volume control shows up after click play, the preview still show no volume control. 

Another message is when this bug happens, there is error on console:
ERR<16772>:ecore ecore_main.c:1509 _ecore_main_fd_handlers_bads_rem() Removing bad fds
ERR<16772>:ecore ecore_main.c:1551 _ecore_main_fd_handlers_bads_rem() No bad fd found. Maybe a foreign fd from glib?

I'll continue to dig out the root cause.

[Halton Huo]

Created attachment 180846 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 180846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180846&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:-1084
> -    return (part != MediaMuteButtonPart);

Bug 97574 implemented this function before. https://bugs.webkit.org/show_bug.cgi?id=97574#c0

Did you test this case ?

- media/video-no-audio.html

[Halton Huo]

(In reply to comment #2)
> Did you test this case ?
> 
> - media/video-no-audio.html
The mute/unmute button shows up, as well as GTK port. So my fix should be wrong solution, will continue to work out.

[Kenneth Rohde Christiansen]

Comment on attachment 180846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180846&action=review

> Source/WebCore/ChangeLog:9
> +
> +        Enable state handling for MediaMuteButtonPart so that mute/unmute button could always be shown.
> +

if it always should be shown why does the method then exist?

[Halton Huo]

With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug).

The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing.

Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. 

Ubuntu can follow the instruction at https://wiki.ubuntu.com/Novacut/GStreamer1.0. (libgstreamer1.0-dev and libgstreamer-plugins-base1.0-dev need to be installed also).

[Chris Dumez]

(In reply to comment #5)
> With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug).
> 
> The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing.
> 
> Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. 

The EFL port already builds with gstreamer 1.0. It is part of jhbuild.

[Chris Dumez]

(In reply to comment #6)
> (In reply to comment #5)
> > With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug).
> > 
> > The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing.
> > 
> > Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. 
> 
> The EFL port already builds with gstreamer 1.0. It is part of jhbuild.

Just pull later trunk and pass "--update-efl" to the build-webkit script. It will pull and build gstreamer 1.0.

[Halton Huo]

Yes, this bug disappear with trunk@139434, so close as dup of bug #106178

*** This bug has been marked as a duplicate of bug 106178 ***