Bug 99757 - [EFL] Buildfix if Netscape plugin support is disabled
Summary: [EFL] Buildfix if Netscape plugin support is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-18 14:07 PDT by Laszlo Gombos
Modified: 2012-10-19 00:36 PDT (History)
7 users (show)

See Also:


Attachments
proposed patch (2.21 KB, patch)
2012-10-18 14:18 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-10-18 14:07:38 PDT
"build-webkit --no-netscape-plugin-api --efl" does not build.
Comment 1 Laszlo Gombos 2012-10-18 14:18:07 PDT
Created attachment 169475 [details]
proposed patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-10-18 14:34:21 PDT
If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix.
Comment 3 Viatcheslav Ostapenko 2012-10-18 15:09:31 PDT
(In reply to comment #2)
> If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix.

No, it fixes build if plugins are disabled. By default they are enabled.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-10-18 15:34:39 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix.
> 
> No, it fixes build if plugins are disabled. By default they are enabled.

Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then?
Comment 5 Viatcheslav Ostapenko 2012-10-18 15:37:44 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix.
> > 
> > No, it fixes build if plugins are disabled. By default they are enabled.
> 
> Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then?

Yes, it should fix --no-netscape-plugin-api build.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-10-18 16:11:08 PDT
(In reply to comment #5)
> > Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then?
> 
> Yes, it should fix --no-netscape-plugin-api build.

Right. If it addresses Mariusz's concerns in that bug report, I guess it should be fine. Once it lands, please comment on that bug so that everyone knows the issue has been fixed.
Comment 7 Gyuyoung Kim 2012-10-18 19:12:55 PDT
Comment on attachment 169475 [details]
proposed patch

It would be good if you say this is fixed on the Rafael's comment. :-)
Comment 8 WebKit Review Bot 2012-10-18 19:35:57 PDT
Comment on attachment 169475 [details]
proposed patch

Clearing flags on attachment: 169475

Committed r131843: <http://trac.webkit.org/changeset/131843>
Comment 9 WebKit Review Bot 2012-10-18 19:36:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Mariusz Grzegorczyk 2012-10-19 00:36:59 PDT
This is a part of bigger problem. See following bug:
https://bugs.webkit.org/show_bug.cgi?id=98401