"build-webkit --no-netscape-plugin-api --efl" does not build.
Created attachment 169475 [details] proposed patch
If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix.
(In reply to comment #2) > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. No, it fixes build if plugins are disabled. By default they are enabled.
(In reply to comment #3) > (In reply to comment #2) > > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. > > No, it fixes build if plugins are disabled. By default they are enabled. Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then?
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. > > > > No, it fixes build if plugins are disabled. By default they are enabled. > > Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then? Yes, it should fix --no-netscape-plugin-api build.
(In reply to comment #5) > > Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then? > > Yes, it should fix --no-netscape-plugin-api build. Right. If it addresses Mariusz's concerns in that bug report, I guess it should be fine. Once it lands, please comment on that bug so that everyone knows the issue has been fixed.
Comment on attachment 169475 [details] proposed patch It would be good if you say this is fixed on the Rafael's comment. :-)
Comment on attachment 169475 [details] proposed patch Clearing flags on attachment: 169475 Committed r131843: <http://trac.webkit.org/changeset/131843>
All reviewed patches have been landed. Closing bug.
This is a part of bigger problem. See following bug: https://bugs.webkit.org/show_bug.cgi?id=98401