RESOLVED WONTFIX 98401
Compile PLUGIN_PROCESS code only when NETSCAPE_PLUGIN_API macro is on 
https://bugs.webkit.org/show_bug.cgi?id=98401
Summary Compile PLUGIN_PROCESS code only when NETSCAPE_PLUGIN_API macro is on
Mariusz Grzegorczyk
Reported 2012-10-04 05:48:27 PDT
In webkit2 there are some places where code related with plugin process is guarded by only PLUGIN_PROCESS macro, and in other places with both PLUGIN_PROCESS and NETSCAPE_PLUGIN_API. Following commit tries to make some cleanup: "Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API) https://bugs.webkit.org/show_bug.cgi?id=86496" Files like UIProcess/Plugins/PluginProcessProxy.cpp are being taken to compile always, and inside them at the beginning there is #if ENABLE(PLUGIN_PROCESS) guard. I think that in all places also NETSCAPE_PLUGIN_API check should be added. If plugins are off PLUGIN_PROCESS's code shouldn't be compiled. Other example: PluginProxyQt.cpp has guard #if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API), while PluginProxy.h only #if ENABLE(PLUGIN_PROCESS)
Attachments
Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2013-08-17 10:06:39 PDT
This is related to 89451, probably a duplicate.
Philip Chimento
Comment 2 2015-01-06 19:16:05 PST
Duplicate of https://bugs.webkit.org/show_bug.cgi?id=98262 I think?
Carlos Garcia Campos
Comment 3 2015-01-07 05:35:06 PST
(In reply to comment #2) > Duplicate of https://bugs.webkit.org/show_bug.cgi?id=98262 I think? No it's not, if ENABLE_PLUGIN_PROCESS was false when ENABLE_NETSCAPE_PLUGIN_API is false you wouldn't need most of the #ifdefs you are adding in bug #98262
Brent Fulgham
Comment 4 2022-07-01 10:45:25 PDT
WebKit no longer support NPAPI plugins.
Note You need to log in before you can comment on or make changes to this bug.