This bug will cover enabling Indexed Database feature on the GTK port.
*** Bug 94495 has been marked as a duplicate of this bug. ***
Created attachment 245226 [details] Patch
Weird build error in our EWS again, look unrelated to the patch.
Committed r179107: <http://trac.webkit.org/changeset/179107>
Re-opened since this is blocked by bug 140880
So, we need to either bump the minimum GCC version required or remove the AsyncTask implementation using C++ lambdas, see bug #140881.
(In reply to comment #6) > So, we need to either bump the minimum GCC version required or remove the > AsyncTask implementation using C++ lambdas, see bug #140881. Maybe we can bump the GCC requirements now for the new cycle. Debian stable has 4.9.2, we should probably update our bots to jessie at some point this cycle. It's a shame this feature is blocked by a compiler bug.
(In reply to comment #7) > (In reply to comment #6) > > So, we need to either bump the minimum GCC version required or remove the > > AsyncTask implementation using C++ lambdas, see bug #140881. > > Maybe we can bump the GCC requirements now for the new cycle. Debian stable > has 4.9.2, we should probably update our bots to jessie at some point this > cycle. It's a shame this feature is blocked by a compiler bug. Let's just make indexed database depend on the newer version of GCC. This should be pretty easy. It's the path of least resistance while we figure out what to do. We'll need too coordinate updating the bots.
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > So, we need to either bump the minimum GCC version required or remove the > > > AsyncTask implementation using C++ lambdas, see bug #140881. > > > > Maybe we can bump the GCC requirements now for the new cycle. Debian stable > > has 4.9.2, we should probably update our bots to jessie at some point this > > cycle. It's a shame this feature is blocked by a compiler bug. > > Let's just make indexed database depend on the newer version of GCC. This > should be pretty easy. It's the path of least resistance while we figure out > what to do. We'll need too coordinate updating the bots. Note that the latest LTS version of Ubuntu only has 14.10, but we can recommend clang in that case hopefully.
I don't mind bumping the compiler requirement, since this is a major feature and not just a code cleanup. But looking at the test expectations, is this really ready? It seems enabling IndexedDB will introduce several known crashes....
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > So, we need to either bump the minimum GCC version required or remove the > > > AsyncTask implementation using C++ lambdas, see bug #140881. > > > > Maybe we can bump the GCC requirements now for the new cycle. Debian stable > > has 4.9.2, we should probably update our bots to jessie at some point this > > cycle. It's a shame this feature is blocked by a compiler bug. > > Let's just make indexed database depend on the newer version of GCC. This > should be pretty easy. It's the path of least resistance while we figure out > what to do. We'll need too coordinate updating the bots. I would not make the option depending on the compiler, we will have to upgrade the bots to test indexeddb, so we won't be testing wk build with previous versions of GCC anymore. Or if we don't upgrade the bots to ensure wk still builds with previous versions of GCC we won't be testing indexeddb.
(In reply to comment #10) > I don't mind bumping the compiler requirement, since this is a major feature > and not just a code cleanup. But looking at the test expectations, is this > really ready? It seems enabling IndexedDB will introduce several known > crashes.... I'll check the current status, it's early in the release cycle, we can try to fix those crashes once we have basic support landed.
(In reply to comment #11) > I would not make the option depending on the compiler, we will have to > upgrade the bots to test indexeddb, so we won't be testing wk build with > previous versions of GCC anymore. Or if we don't upgrade the bots to ensure > wk still builds with previous versions of GCC we won't be testing indexeddb. Isn't untested support for a compiler better than dropping support completely?
(In reply to comment #13) > (In reply to comment #11) > > > I would not make the option depending on the compiler, we will have to > > upgrade the bots to test indexeddb, so we won't be testing wk build with > > previous versions of GCC anymore. Or if we don't upgrade the bots to ensure > > wk still builds with previous versions of GCC we won't be testing indexeddb. > > Isn't untested support for a compiler better than dropping support > completely? I don't think so, I prefer to drop support for buggy versions of the compiler, and not making important features depend on the compiler.
Created attachment 253383 [details] Rebased patch Fortunately build still works with indexeddb enabled. I've updated the test expectations, I got only one crash and a lot of other failures (all of them except one common to mac). run-webkit-tests --gtk storage/indexeddb http/tests/security/cross-origin-indexeddb-allowed.html http/tests/security/cross-origin-indexeddb.html http/tests/security/no-indexeddb-from-sandbox.html fast/history/page-cache-indexed-closed-db.html fast/history/page-cache-indexed-opened-db.html Found 236 tests; running 150, skipping 86. Running 4 WebKitTestRunners in parallel. All 150 tests ran as expected.
(In reply to comment #8) > We'll need too coordinate updating the bots. I have just updated the 4 bots that I control: GTK Linux 64-bit Debug (Build) GTK Linux 64-bit Debug (Tests) GTK Linux 64-bit Release (Build) GTK Linux 64-bit Release (Perf) GTK Linux 64-bit Release (Tests) They are now all running Debian 8.0 with gcc-4.9.
GCC 4.9 also available on both I maintain now =)
Created attachment 253439 [details] Trying again now that EWS bots have new GCC
Committed r184850: <http://trac.webkit.org/changeset/184850>