Bug 140882 - [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
Summary: [GTK] Add construct property to WebKitWebContext to set the IndexedDB databas...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 98932
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-26 02:19 PST by Carlos Garcia Campos
Modified: 2015-05-25 08:16 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.67 KB, patch)
2015-01-26 02:23 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (7.48 KB, patch)
2015-05-25 02:39 PDT, Carlos Garcia Campos
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-01-26 02:19:44 PST
Similar to the local-storage-directory, it should be set on construction.
Comment 1 Carlos Garcia Campos 2015-01-26 02:23:37 PST
Created attachment 245335 [details]
Patch

We need to enable IndexedDB again first, see bug #98932
Comment 2 WebKit Commit Bot 2015-01-26 02:24:49 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Gustavo Noronha (kov) 2015-01-28 03:23:19 PST
Comment on attachment 245335 [details]
Patch

I feel like we should drop the -database part from the name since 'db' already means that and it is not easy to confuse this with something that is not a database. Otherwise looks good.
Comment 4 Carlos Garcia Campos 2015-01-28 03:27:53 PST
(In reply to comment #3)
> Comment on attachment 245335 [details]
> Patch
> 
> I feel like we should drop the -database part from the name since 'db'
> already means that and it is not easy to confuse this with something that is
> not a database. Otherwise looks good.

Yes, I thought about that, and added the -directory because db is part of the IndexedDB, but what other thing could be the directory for? I'll update the patch, thanks for the review!
Comment 5 Carlos Garcia Campos 2015-05-25 02:39:49 PDT
Created attachment 253677 [details]
Updated patch
Comment 6 Gustavo Noronha (kov) 2015-05-25 04:29:44 PDT
Comment on attachment 253677 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253677&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:345
> +     * WebKitWebContext:indexed-db-database-directory:

Still has the -database bit.
Comment 7 Carlos Garcia Campos 2015-05-25 04:30:36 PDT
(In reply to comment #6)
> Comment on attachment 253677 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253677&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:345
> > +     * WebKitWebContext:indexed-db-database-directory:
> 
> Still has the -database bit.

Oops, good catch!
Comment 8 Carlos Garcia Campos 2015-05-25 08:16:02 PDT
Committed r184851: <http://trac.webkit.org/changeset/184851>