Bug 145211 – [GTK] Bump GCC requirements to 4.9.0

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

It's required to build with IndexedDB support when using GCC, clang works just fine. All the bots have already been upgraded.

[Carlos Garcia Campos]

Created attachment 253440 [details]
Patch

[Zan Dobersek]

EWS machines apparently haven't been updated.

[Carlos Garcia Campos]

Created attachment 253441 [details]
Patch

[Carlos Garcia Campos]

(In reply to comment #2)
> EWS machines apparently haven't been updated.

They were, see green boxes in bug #98932, but I think CMake stupid cache still had the old compiler version somewhere.

[Zan Dobersek]

Comment on attachment 253441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253441&action=review

> Source/cmake/OptionsGTK.cmake:10
> +# IndexedDB support requires GGC 4.9, see https://bugs.webkit.org/show_bug.cgi?id=98932.

GCC*.

[Carlos Garcia Campos]

(In reply to comment #5)
> Comment on attachment 253441 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253441&action=review
> 
> > Source/cmake/OptionsGTK.cmake:10
> > +# IndexedDB support requires GGC 4.9, see https://bugs.webkit.org/show_bug.cgi?id=98932.
> 
> GCC*.

Oops. Thanks for the review, I'll wait for EWS anyway, and even more important for Martin's approval since he was not convinced yet to bump requirements.

[Carlos Garcia Campos]

Martin?

[Martin Robinson]

(In reply to comment #7)
> Martin?

It seems pretty simple to make the build conditional. If we need to do that we can go back and do it later, so I'm not going to block this. :)

[Carlos Garcia Campos]

Committed r184849: <http://trac.webkit.org/changeset/184849>