Bug 98724 - [EFL] Remove "web" word in web inspector
Summary: [EFL] Remove "web" word in web inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-08 23:16 PDT by Gyuyoung Kim
Modified: 2012-10-11 18:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (57.67 KB, patch)
2012-10-08 23:25 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (57.66 KB, patch)
2012-10-09 00:35 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (19.26 KB, patch)
2012-10-09 04:29 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-10-08 23:16:08 PDT
Remove "web" word from ewk files in order to be consistent with WK2. Bug 97886 and Bug 97887 removed *web* from WK2.

This was discussed in webkit-efl mailing list.
http://lists.webkit.org/pipermail/webkit-efl/2012-September/000308.html.
Comment 1 Gyuyoung Kim 2012-10-08 23:25:49 PDT
Created attachment 167695 [details]
Patch
Comment 2 Gyuyoung Kim 2012-10-09 00:35:09 PDT
Created attachment 167702 [details]
Patch
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-10-09 03:03:55 PDT
I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database).
Comment 4 Jongseok Yang 2012-10-09 03:16:31 PDT
(In reply to comment #3)
> I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database).

The WK API name for Web Database is just WKDatabaseXXXXX.
So, I think that we can remove "web" word from the implementation for web databases.
Comment 5 Gyuyoung Kim 2012-10-09 03:47:21 PDT
(In reply to comment #3)
> I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database).

As Raphael said, we may argue with web database and web audio in WK1. Because other ports in WK1 are still using *web*. It looks I need to consider this further. 

BTW, how about removing web from web_inspector ? I think *web* is redundant in inspector.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-10-09 04:02:02 PDT
(In reply to comment #5)
> (In reply to comment #3)
> > I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database).
> 
> As Raphael said, we may argue with web database and web audio in WK1. Because other ports in WK1 are still using *web*. It looks I need to consider this further. 
> 
> BTW, how about removing web from web_inspector ? I think *web* is redundant in inspector.

Yeah, I think removing this one is OK.
Comment 7 Gyuyoung Kim 2012-10-09 04:29:05 PDT
Created attachment 167732 [details]
Patch
Comment 8 Gyuyoung Kim 2012-10-09 04:30:32 PDT
I only remove *web* from web inspector. Other will be considered further. Jongseok and Seokju, how do you think ?
Comment 9 Gyuyoung Kim 2012-10-09 04:31:58 PDT
Beside other ports just use *inspector* except for gtk and win ports.
Comment 10 Raphael Kubo da Costa (:rakuco) 2012-10-09 09:37:24 PDT
Comment on attachment 167732 [details]
Patch

LGTM
Comment 11 Seokju Kwon 2012-10-11 18:01:17 PDT
(In reply to comment #8)
> I only remove *web* from web inspector. Other will be considered further. Jongseok and Seokju, how do you think ?

No problem. I have also removed "web" from web inspector on Bug 98639.
Comment 12 Laszlo Gombos 2012-10-11 18:03:10 PDT
Comment on attachment 167732 [details]
Patch

This change makes the api more consistent.

r=me.
Comment 13 WebKit Review Bot 2012-10-11 18:19:27 PDT
Comment on attachment 167732 [details]
Patch

Clearing flags on attachment: 167732

Committed r131119: <http://trac.webkit.org/changeset/131119>
Comment 14 WebKit Review Bot 2012-10-11 18:19:32 PDT
All reviewed patches have been landed.  Closing bug.