Bug 97886 – [EFL][WK2] Remove "web" word from ewk_web_error APIs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jongseok Yang]

"ewk" means "EFL WebKit" and the name of orignal WK APIs for ewk_web_error APIs does not include "web" word.
So, it' better to remove "web" word from them.

The patch will be uploaded soon.

[Jongseok Yang]

Created attachment 167208 [details]
Patch

[WebKit Review Bot]

Attachment 167208 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/efl/EWebKit2.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Tools/MiniBrowser/efl/main.c:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jongseok Yang]

Created attachment 167211 [details]
Patch

[WebKit Review Bot]

Attachment 167211 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Tools/MiniBrowser/efl/main.c:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jongseok Yang]

Created attachment 167213 [details]
Patch

[WebKit Review Bot]

Attachment 167213 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Tools/MiniBrowser/efl/main.c:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

Comment on attachment 167213 [details]
Patch

Did you run Tools/Scripts/check-webkit-style before submitting patch ?

[Jongseok Yang]

Created attachment 167216 [details]
Patch

[WebKit Review Bot]

Attachment 167216 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Tools/MiniBrowser/efl/main.c:194:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jongseok Yang]

Created attachment 167218 [details]
Patch

[Jongseok Yang]

(In reply to comment #7)
> (From update of attachment 167213 [details])
> Did you run Tools/Scripts/check-webkit-style before submitting patch ?

I'm sorry that I uploaded wrong patch file.
Please check new one.

[Gyuyoung Kim]

Comment on attachment 167218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167218&action=review

> Source/WebKit2/ChangeLog:10
> +

It would be good if you say where this removal is discussed.

http://lists.webkit.org/pipermail/webkit-efl/2012-September/000308.html

[Chris Dumez]

Comment on attachment 167218 [details]
Patch

LGTM. Thanks.

[WebKit Review Bot]

Comment on attachment 167218 [details]
Patch

Rejecting attachment 167218 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
web_error_private.h'
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/MiniBrowser/efl/main.c
Hunk #1 succeeded at 189 (offset 2 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gyuyoung K..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14171621

[Jongseok Yang]

Created attachment 167287 [details]
Patch

[Jongseok Yang]

ewk_web_error_free function was moved from public header to private header by Ryuan Choi's patch.
So, I rebased the patch.

[Jongseok Yang]

Created attachment 167304 [details]
Patch

[Jongseok Yang]

I rebased the patch

[WebKit Review Bot]

Comment on attachment 167304 [details]
Patch

Clearing flags on attachment: 167304

Committed r130494: <http://trac.webkit.org/changeset/130494>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.