Bug 97887 - [EFL][WK2] Remove "web" word from ewk_resource APIs
Summary: [EFL][WK2] Remove "web" word from ewk_resource APIs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Jongseok Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 03:50 PDT by Jongseok Yang
Modified: 2012-10-05 00:46 PDT (History)
5 users (show)

See Also:

Attachments
Patch (33.35 KB, patch)
2012-10-04 19:46 PDT, Jongseok Yang 		no flags Details | Formatted Diff | Diff
Patch (33.34 KB, patch)
2012-10-04 19:56 PDT, Jongseok Yang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jongseok Yang 2012-09-28 03:50:22 PDT 
"ewk" means "EFL WebKit" and "web" word for the name ewk_web_resource implementation is redundant.
So, it' better to remove "web" word from them.

The patch will be uploaded soon.
Comment 1 Jongseok Yang 2012-10-04 19:46:56 PDT 
Created attachment 167235 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-04 19:49:02 PDT 
Attachment 167235 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/efl/ewk_resource.cpp:34:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jongseok Yang 2012-10-04 19:56:32 PDT 
Created attachment 167236 [details]
Patch
Comment 4 Chris Dumez 2012-10-04 22:36:52 PDT 
Comment on attachment 167236 [details]
Patch

Looks good. Thanks.
Comment 5 Gyuyoung Kim 2012-10-05 00:39:07 PDT 
For the record, http://lists.webkit.org/pipermail/webkit-efl/2012-September/000308.html
Comment 6 WebKit Review Bot 2012-10-05 00:46:49 PDT 
Comment on attachment 167236 [details]
Patch

Clearing flags on attachment: 167236

Committed r130479: <http://trac.webkit.org/changeset/130479>
Comment 7 WebKit Review Bot 2012-10-05 00:46:53 PDT 
All reviewed patches have been landed.  Closing bug.