We should start using X11 in EFL's DumpRenderTree now that we are using XvfbDriver for the layout tests.
Created attachment 166810 [details] Patch
Comment on attachment 166810 [details] Patch Needs the same in WKTR.
Created attachment 166813 [details] Patch Apply same change to WebKitTestRunner.
Created attachment 166816 [details] Patch Properly initialize ecore_x library in ewk_main.
Comment on attachment 166816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166816&action=review > Source/WebKit/efl/ewk/ewk_main.cpp:101 > + if (!ecore_x_init(0)) { Are those init calls are order dependant? ecore_x_init is not, but I'm just curious how edje and evas objects are initialized. > Source/WebKit/efl/ewk/ewk_main.cpp:116 > + edje_shutdown(); Should it be ecore_x_shutdown() ?
Comment on attachment 166816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166816&action=review >> Source/WebKit/efl/ewk/ewk_main.cpp:101 >> + if (!ecore_x_init(0)) { > > Are those init calls are order dependant? > ecore_x_init is not, but I'm just curious how edje and evas objects are initialized. I don't believe they are. >> Source/WebKit/efl/ewk/ewk_main.cpp:116 >> + edje_shutdown(); > > Should it be ecore_x_shutdown() ? No, this is correct. We come to this label if ecore_x_init() failed so there is no need to call ecore_x_shutdown(). We however, need to shutdown the previously intialized library (edje). See error_edje: 2 lines below, it calls ecore_evas_shutdown(), not edje_shutdown().
(In reply to comment #6) > (From update of attachment 166816 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166816&action=review > > >> Source/WebKit/efl/ewk/ewk_main.cpp:101 > >> + if (!ecore_x_init(0)) { > > > > Are those init calls are order dependant? > > ecore_x_init is not, but I'm just curious how edje and evas objects are initialized. > > I don't believe they are. > > >> Source/WebKit/efl/ewk/ewk_main.cpp:116 > >> + edje_shutdown(); > > > > Should it be ecore_x_shutdown() ? > > No, this is correct. We come to this label if ecore_x_init() failed so there is no need to call ecore_x_shutdown(). We however, need to shutdown the previously intialized library (edje). See error_edje: 2 lines below, it calls ecore_evas_shutdown(), not edje_shutdown(). LGTM! Thanks.
Comment on attachment 166816 [details] Patch Alright, looks fine, thanks!
Comment on attachment 166816 [details] Patch Clearing flags on attachment: 166816 Committed r130363: <http://trac.webkit.org/changeset/130363>
All reviewed patches have been landed. Closing bug.