Bug 98389 - [EFL] Run unit tests with Xvfb
Summary: [EFL] Run unit tests with Xvfb
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
: 98414 (view as bug list)
Depends on:
Blocks: 98231
  Show dependency treegraph
 
Reported: 2012-10-04 02:44 PDT by Chris Dumez
Modified: 2012-10-05 00:16 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.02 KB, patch)
2012-10-04 06:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-04 02:44:02 PDT
We currently unset the DISPLAY environment variable in setup_environ_for_server() if the variable is not set on the system.
This is an issue now because XvfbDriver sets the DISPLAY environment variable and we don't want to unset it on the bots (where the system does not have DISPLAY environment variable set).
Comment 1 Chris Dumez 2012-10-04 02:49:07 PDT
Our unit tests are failing because of this. We wrongly unset the DISPLAY environment variable and then ecore_x_init() fails on the bots.
Comment 2 Chris Dumez 2012-10-04 06:38:10 PDT
Created attachment 167095 [details]
Patch

This patch fixes unit tests on our build bots by running them with Xvfb.
Comment 3 Laszlo Gombos 2012-10-04 07:37:48 PDT
Comment on attachment 167095 [details]
Patch

r=me.
Comment 4 WebKit Review Bot 2012-10-04 07:45:27 PDT
Comment on attachment 167095 [details]
Patch

Clearing flags on attachment: 167095

Committed r130390: <http://trac.webkit.org/changeset/130390>
Comment 5 WebKit Review Bot 2012-10-04 07:45:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Byungwoo Lee 2012-10-05 00:16:20 PDT
*** Bug 98414 has been marked as a duplicate of this bug. ***