Bug 98162 - [EFL] Use XvfbDriver for layout tests
Summary: [EFL] Use XvfbDriver for layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 88414
Blocks: 98231
  Show dependency tree / graph
 
Reported: 2012-10-02 08:16 PDT by Chris Dumez
Modified: 2012-10-02 22:38 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2012-10-02 08:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-02 08:16:38 PDT 
We should use XvfbDriver for layout tests so that tests that requires a running X server can be unskipped on the build bots.
Comment 1 Chris Dumez 2012-10-02 08:43:00 PDT 
Created attachment 166692 [details]
Patch
Comment 2 Chris Dumez 2012-10-02 09:07:39 PDT 
xvfb is now installed on both Intel build bots.

I added xvfb dependency to:
https://trac.webkit.org/wiki/WebKitEFLLayoutTest
Comment 3 Laszlo Gombos 2012-10-02 09:33:47 PDT 
(In reply to comment #2)
> xvfb is now installed on both Intel build bots.

Is there an expectation on the xvfb version ? Predictability and consistent environment for LayoutTests are very important (and using xvfb should help with that).

IMHO we should recommend the xvfb version that runs on the buildbot. Would that be v2.1.11+ ?
Comment 4 Chris Dumez 2012-10-02 09:36:01 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > xvfb is now installed on both Intel build bots.
> 
> Is there an expectation on the xvfb version ? Predictability and consistent environment for LayoutTests are very important (and using xvfb should help with that).
> 
> IMHO we should recommend the xvfb version that runs on the buildbot. Would that be v2.1.11+ ?

The build bots are running Ubuntu 12.04 so they have xfvb v1.11.4, yes.
Comment 5 WebKit Review Bot 2012-10-02 10:53:25 PDT 
Comment on attachment 166692 [details]
Patch

Clearing flags on attachment: 166692

Committed r130186: <http://trac.webkit.org/changeset/130186>
Comment 6 WebKit Review Bot 2012-10-02 10:53:30 PDT 
All reviewed patches have been landed.  Closing bug.