SSIA
Created attachment 189763 [details] proposed patch This patch depends on https://bugs.webkit.org/show_bug.cgi?id=110565 I have changed movw, tst.w, add.w to mov, tst and add where they weren't necessary.
Comment on attachment 189763 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=189763&action=review > Source/JavaScriptCore/offlineasm/arm.rb:77 > + if isARMv7 or isARMv7Traditional You could use elsif here. Same as above.
ping for review, please :)
After fixing the elsif, this also looks good for me.
Created attachment 193089 [details] proposed patch 2
The patch looks good to me, if there are no objections, we can soon land it.
Just out of curiosity, have you tried an ARMv5 build after this patch?
Comment on attachment 193089 [details] proposed patch 2 r=me.
(In reply to comment #7) > Just out of curiosity, have you tried an ARMv5 build after this patch? Yes I tried it and worked fine on ARMv5 as well.
Comment on attachment 193089 [details] proposed patch 2 Clearing flags on attachment: 193089 Committed r146459: <http://trac.webkit.org/changeset/146459>
All reviewed patches have been landed. Closing bug.