Bug 97203 - Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
Summary: Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 96746 97338
Blocks: 97331
  Show dependency treegraph
 
Reported: 2012-09-20 05:55 PDT by Andrey Adaikin
Modified: 2012-09-24 06:01 PDT (History)
14 users (show)

See Also:


Attachments
Patch (11.77 KB, patch)
2012-09-20 06:03 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff
Try again to land (12.54 KB, patch)
2012-09-24 03:41 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-09-20 05:55:46 PDT
Patch to follow.
Comment 1 Andrey Adaikin 2012-09-20 06:03:53 PDT
Created attachment 164903 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-21 05:33:57 PDT
Comment on attachment 164903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164903&action=review

> Source/WebCore/inspector/InspectorCanvasInstrumentation.h:46
> +        if (canvasAgent && canvasAgent->enabled())

You shouldn't check if the agent is enabled here, it should only set itself in instrumentingAgents when it is enabled instead.
Comment 3 Andrey Adaikin 2012-09-21 05:43:57 PDT
(In reply to comment #2)
> (From update of attachment 164903 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164903&action=review
> 
> > Source/WebCore/inspector/InspectorCanvasInstrumentation.h:46
> > +        if (canvasAgent && canvasAgent->enabled())
> 
> You shouldn't check if the agent is enabled here, it should only set itself in instrumentingAgents when it is enabled instead.

Thanks. Will address this in https://bugs.webkit.org/show_bug.cgi?id=97331
Comment 4 WebKit Review Bot 2012-09-21 05:51:57 PDT
Comment on attachment 164903 [details]
Patch

Clearing flags on attachment: 164903

Committed r129219: <http://trac.webkit.org/changeset/129219>
Comment 5 WebKit Review Bot 2012-09-21 05:52:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-09-21 07:18:51 PDT
Re-opened since this is blocked by 97338
Comment 7 Andrey Adaikin 2012-09-24 03:41:07 PDT
Created attachment 165345 [details]
Try again to land
Comment 8 WebKit Review Bot 2012-09-24 06:01:12 PDT
Comment on attachment 165345 [details]
Try again to land

Clearing flags on attachment: 165345

Committed r129353: <http://trac.webkit.org/changeset/129353>
Comment 9 WebKit Review Bot 2012-09-24 06:01:16 PDT
All reviewed patches have been landed.  Closing bug.