Bug 96746 – Web Inspector: [WebGL] First step towards 2D canvas instrumentation in injected script

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Adaikin]

First step towards the 2D canvas instrumentation from the WebGL injected script module side.
Next: support this from the inspector instrumentation C++ code.
Next: rename [WebGL] to [Canvas]

[Andrey Adaikin]

Created attachment 164087 [details]
Patch

[Andrey Adaikin]

Note for reviewers:
- Canvas 2D context specs: http://www.w3.org/TR/2dcontext/
- Excerpts about the 2D context state:

Each context maintains a stack of drawing states. Drawing states consist of:

- The current transformation matrix.
- The current clipping region.
- The current values of the following attributes:
    strokeStyle, fillStyle, globalAlpha, lineWidth, lineCap, lineJoin, miterLimit, shadowOffsetX, shadowOffsetY, shadowBlur, shadowColor, globalCompositeOperation, font, textAlign, textBaseline.
- The current default path is NOT part of the drawing state. The current default path is persistent, and can only be reset using the beginPath() method.

[Vsevolod Vlasov]

Comment on attachment 164087 [details]
Patch

Please explain what you are doing here in ChangeLog.

[Andrey Adaikin]

Created attachment 164706 [details]
Patch

[Andrey Adaikin]

Created attachment 164893 [details]
Rebased

[Andrey Adaikin]

Created attachment 165387 [details]
Rebased

[WebKit Review Bot]

Comment on attachment 165387 [details]
Rebased

Rejecting attachment 165387 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 165387 [details]
Rebased

Clearing flags on attachment: 165387

Committed r129383: <http://trac.webkit.org/changeset/129383>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.