Bug 97331 - Web Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling enable command
Summary: Web Inspector: [Canvas] set CanvasAgent in InstrumentingAgents upon calling e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 97203
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-21 05:43 PDT by Andrey Adaikin
Modified: 2012-09-24 08:47 PDT (History)
11 users (show)

See Also:


Attachments
Patch (5.51 KB, patch)
2012-09-24 08:19 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-09-21 05:43:23 PDT
We should set CanvasAgent in InstrumentingAgents from enable() command and remove from disable(), instead of doing this in constructor and destructor.

Patch to follow.
Comment 1 Andrey Adaikin 2012-09-24 08:19:11 PDT
Created attachment 165386 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-24 08:47:00 PDT
Comment on attachment 165386 [details]
Patch

Clearing flags on attachment: 165386

Committed r129374: <http://trac.webkit.org/changeset/129374>
Comment 3 WebKit Review Bot 2012-09-24 08:47:03 PDT
All reviewed patches have been landed.  Closing bug.