Bug 96226 – REGRESSION (r128006): Three spatial navigation tests are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

After <http://trac.webkit.org/r128006>, fast/spatial-navigation/snav-container-white-space.html, fast/spatial-navigation/snav-div-overflow-scrol-hidden.html, and fast/spatial-navigation/snav-imagemap-overlapped-areas.html are failing.

r128006 was the fix for bug 81413.

[Csaba Osztrogonác]

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/spatial-navigation/snav-container-white-space-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/spatial-navigation/snav-container-white-space-actual.txt 
@@ -4,10 +4,10 @@
 This is an element
   
 This is an element
-PASS gFocusedDocument.activeElement.getAttribute("id") is "1"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "2"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "3"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "4"
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 1. Was 2.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 2. Was 3.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 3. Was 4.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 4. Was 5.
 PASS gFocusedDocument.activeElement.getAttribute("id") is "5"
 PASS gFocusedDocument.activeElement.getAttribute("id") is "4"
 PASS gFocusedDocument.activeElement.getAttribute("id") is "3"


--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/spatial-navigation/snav-div-overflow-scrol-hidden-actual.txt 
@@ -9,10 +9,10 @@
 
 PASS gFocusedDocument.activeElement.getAttribute("id") is "f2"
 PASS gFocusedDocument.activeElement.getAttribute("id") is "f3"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "f3"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "f4"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "f4"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "f5"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "f6"
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be f3. Was f4.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be f4. Was f5.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be f4. Was f6.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be f5. Was f6.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be f6. Was f9.
 PASS gFocusedDocument.activeElement.getAttribute("id") is "f9"
 This test is testing that div with overflow:auto would scroll, by div with overflow:hidden would not.


--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/spatial-navigation/snav-imagemap-overlapped-areas-actual.txt 
@@ -1,9 +1,9 @@
  
 
 
-PASS gFocusedDocument.activeElement.getAttribute("id") is "4"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "1"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "2"
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 4. Was 1.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 1. Was 2.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be 2. Was 5.
 PASS gFocusedDocument.activeElement.getAttribute("id") is "5"
 PASS gFocusedDocument.activeElement.getAttribute("id") is "4"
 PASS gFocusedDocument.activeElement.getAttribute("id") is "3"

[Csaba Osztrogonác]

I skipped them on Qt - https://trac.webkit.org/changeset/128017.
Please unskip with the proper fix.

[Chris Dumez]

I'm skipping those tests for EFL port in Bug 96233.
Please unskip them with proper fix. TIA.

[Zan Dobersek]

Seems a bit like disabled subpixel rendering could be the issue as the tests seem to behave OK on Chromium:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fspatial-navigation

Added the failing tests to the Mac skip list in r128060.

[Emil A Eklund]

Thanks, looking into it.

[Emil A Eklund]

Created attachment 163744 [details]
Patch

[Emil A Eklund]

I still plan to remove those methods but due to an unexpected edge case it'll take longer than I had though, so for now I'm reverting.

[Ryosuke Niwa]

Comment on attachment 163744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163744&action=review

rs=me. I've verified that this patch reverts http://trac.webkit.org/changeset/128006/trunk/Source/WebCore/dom/ContainerNode.cpp.

> Source/WebCore/dom/ContainerNode.cpp:762
> +                // do nothing - skip unrendered whitespace that is a child or next sibling of the anchor

Wont indentation.

> Source/WebCore/dom/ContainerNode.cpp:767
> +                           toRenderText(o)->firstTextBox()->root()->lineTop());

Ditto.

[Emil A Eklund]

Created attachment 164024 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 164024 [details]
Patch for landing

Rejecting attachment 164024 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ng file Source/WebCore/dom/ContainerNode.cpp
Hunk #1 succeeded at 727 (offset 7 lines).
patching file Source/WebCore/dom/ContainerNode.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 1006.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13854231

[Emil A Eklund]

Created attachment 164205 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 164205 [details]
Patch for landing

Clearing flags on attachment: 164205

Committed r128644: <http://trac.webkit.org/changeset/128644>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tullio Lucena]

Created attachment 166986 [details]
Unskipping the tests of this bug, there are passing and the bug was fixed yet.

[Tullio Lucena]

Created attachment 167585 [details]
Patch

Updating patch

[Csaba Osztrogonác]

Comment on attachment 167585 [details]
Patch

unskipped by https://bugs.webkit.org/show_bug.cgi?id=96226

[Csaba Osztrogonác]

Comment on attachment 167585 [details]
Patch

unskipped by https://trac.webkit.org/changeset/130752

[Jessie Berlin]

*** Bug 96438 has been marked as a duplicate of this bug. ***