Bug 95996 – [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Rick Byers]

[chromium] Don't use WebGestureEvent.boundingBox for touch adjustment

[Rick Byers]

Created attachment 162538 [details]
Patch

[Rick Byers]

trchen@ It looks like you recently added another use of GestureEvent boundingBox, so I missed this one in transitioning all the usages to the new fields in bug 95573.  Does this simple change look OK to you?

[Tien-Ren Chen]

You may also want to comment out WebFrameTest.DisambiguationPopupTest for now.

I have one question regarding to the definition of width and height. So (event.x, event.y) is always the top left corner of the fat tap area, and the area extends to (event.x + event.width, event.y + event.height)?

From the chromium side change I thought (event.x, event.y) is the center and the area extends for (+-event.width, +-event.height).

Thanks for the help!

[Rick Byers]

Created attachment 162590 [details]
Patch

[Rick Byers]

(In reply to comment #3)
> You may also want to comment out WebFrameTest.DisambiguationPopupTest for now.

The fix looks simple enough, OK if I just make it?  I'm not sure how to run the test though - in my build webkit_unit_tests doesn't include WebFrameTests, but from the .gypi it doesn't appear to be Android specific or anything so not sure why.

> I have one question regarding to the definition of width and height. So (event.x, event.y) is always the top left corner of the fat tap area, and the area extends to (event.x + event.width, event.y + event.height)?
> 
> From the chromium side change I thought (event.x, event.y) is the center and the area extends for (+-event.width, +-event.height).

Yes, sorry - you're right.  (event.x, event.y) is the center, and width/height represent the total width, so bounding box extends from event.x-width/2 to event.x+width/2 etc.

[Rick Byers]

Ping - does this look OK to you know trchen@?

[Adam Barth]

Comment on attachment 162590 [details]
Patch

Looks reasonable to me.  Please check with trchen before landing.

[Tien-Ren Chen]

(In reply to comment #6)
> Ping - does this look OK to you know trchen@?

LGTM. Great thanks for the explaination!

[Rick Byers]

Great, thanks.  Can someone put this in the CQ for me please?  I want to get this gardened into chromium ASAP so I can start the process of removing these old fields before someone starts using them somewhere else ;-)

[WebKit Review Bot]

Comment on attachment 162590 [details]
Patch

Clearing flags on attachment: 162590

Committed r128058: <http://trac.webkit.org/changeset/128058>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.