Bug 95573 - [chromium] WebGestureEvent deltaX/deltaY fields are overloaded
Summary: [chromium] WebGestureEvent deltaX/deltaY fields are overloaded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rick Byers
URL:
Keywords:
Depends on:
Blocks: 93123 95496
  Show dependency tree / graph
 
Reported: 2012-08-31 08:06 PDT by Rick Byers
Modified: 2012-09-05 21:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (16.69 KB, patch)
2012-08-31 09:42 PDT, Rick Byers 		no flags Details | Formatted Diff | Diff
Update bug number in ChangeLog (16.69 KB, patch)
2012-09-04 07:10 PDT, Rick Byers 		no flags Details | Formatted Diff | Diff
jamesr cr feedback (16.68 KB, patch)
2012-09-04 09:17 PDT, Rick Byers 		no flags Details | Formatted Diff | Diff
Update ChangeLog with chromium CL numbers (16.62 KB, patch)
2012-09-05 11:07 PDT, Rick Byers 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Byers 2012-08-31 08:06:26 PDT 
Split out from bug 93123 which covers PlatformGestureEvent.
First I'll fix chromium's WebGestureEvent.
Comment 1 Rick Byers 2012-08-31 09:42:15 PDT 
Created attachment 161721 [details]
Patch
Comment 2 Rick Byers 2012-09-04 06:48:18 PDT 
Comment on attachment 161721 [details]
Patch

I can't land this until http://codereview.chromium.org/10895024/ lands, but other than updating the ChangeLog with the right chromium revision number, I don't have any other changes planned so we might as well start reviewing this now.
Comment 3 Rick Byers 2012-09-04 07:10:18 PDT 
Created attachment 162037 [details]
Update bug number in ChangeLog
Comment 4 James Robinson 2012-09-04 09:00:35 PDT 
Comment on attachment 162037 [details]
Update bug number in ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159
> +        event.data.scrollUpdate.deltaX =
> +            static_cast<float>(arguments[0].toDouble());
> +        event.data.scrollUpdate.deltaY =
> +            static_cast<float>(arguments[1].toDouble());

no need to line wrap - this is WebKit

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1178
> +            event.data.tap.tapCount =
> +                static_cast<float>(arguments[2].toDouble());

no line wrapping here

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1240
> +    event.data.flingStart.velocityX =
> +        static_cast<float>(arguments[2].toDouble());
> +    event.data.flingStart.velocityY =
> +        static_cast<float>(arguments[3].toDouble());

same
Comment 5 Rick Byers 2012-09-04 09:13:50 PDT 
Comment on attachment 162037 [details]
Update bug number in ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review

>> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159
>> +            static_cast<float>(arguments[1].toDouble());
> 
> no need to line wrap - this is WebKit

Thanks.  Going back and forth on this 6-way handshake isn't making it any easier for me to get use to WebKit style vs. chromium style ;-)
Comment 6 Rick Byers 2012-09-04 09:17:18 PDT 
Created attachment 162050 [details]
jamesr cr feedback
Comment 7 James Robinson 2012-09-04 10:16:50 PDT 
Comment on attachment 162050 [details]
jamesr cr feedback

Looks good, although we can't land yet.
Comment 8 Rick Byers 2012-09-05 11:07:53 PDT 
Created attachment 162290 [details]
Update ChangeLog with chromium CL numbers
Comment 9 Rick Byers 2012-09-05 11:18:35 PDT 
Thanks James!
Comment 10 WebKit Review Bot 2012-09-05 21:46:16 PDT 
Comment on attachment 162290 [details]
Update ChangeLog with chromium CL numbers

Clearing flags on attachment: 162290

Committed r127689: <http://trac.webkit.org/changeset/127689>
Comment 11 WebKit Review Bot 2012-09-05 21:46:20 PDT 
All reviewed patches have been landed.  Closing bug.