Bug 95573 – [chromium] WebGestureEvent deltaX/deltaY fields are overloaded

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Rick Byers]

Split out from bug 93123 which covers PlatformGestureEvent.
First I'll fix chromium's WebGestureEvent.

[Rick Byers]

Created attachment 161721 [details]
Patch

[Rick Byers]

Comment on attachment 161721 [details]
Patch

I can't land this until http://codereview.chromium.org/10895024/ lands, but other than updating the ChangeLog with the right chromium revision number, I don't have any other changes planned so we might as well start reviewing this now.

[Rick Byers]

Created attachment 162037 [details]
Update bug number in ChangeLog

[James Robinson]

Comment on attachment 162037 [details]
Update bug number in ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159
> +        event.data.scrollUpdate.deltaX =
> +            static_cast<float>(arguments[0].toDouble());
> +        event.data.scrollUpdate.deltaY =
> +            static_cast<float>(arguments[1].toDouble());

no need to line wrap - this is WebKit

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1178
> +            event.data.tap.tapCount =
> +                static_cast<float>(arguments[2].toDouble());

no line wrapping here

> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1240
> +    event.data.flingStart.velocityX =
> +        static_cast<float>(arguments[2].toDouble());
> +    event.data.flingStart.velocityY =
> +        static_cast<float>(arguments[3].toDouble());

same

[Rick Byers]

Comment on attachment 162037 [details]
Update bug number in ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=162037&action=review

>> Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp:1159
>> +            static_cast<float>(arguments[1].toDouble());
> 
> no need to line wrap - this is WebKit

Thanks.  Going back and forth on this 6-way handshake isn't making it any easier for me to get use to WebKit style vs. chromium style ;-)

[Rick Byers]

Created attachment 162050 [details]
jamesr cr feedback

[James Robinson]

Comment on attachment 162050 [details]
jamesr cr feedback

Looks good, although we can't land yet.

[Rick Byers]

Created attachment 162290 [details]
Update ChangeLog with chromium CL numbers

[Rick Byers]

Thanks James!

[WebKit Review Bot]

Comment on attachment 162290 [details]
Update ChangeLog with chromium CL numbers

Clearing flags on attachment: 162290

Committed r127689: <http://trac.webkit.org/changeset/127689>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.