Bug 95496 - [chromium] Remove unused WebGestureEvent fields
Summary: [chromium] Remove unused WebGestureEvent fields
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rick Byers
Depends on: 95573 95996
  Show dependency treegraph
Reported: 2012-08-30 13:43 PDT by Rick Byers
Modified: 2012-09-12 16:16 PDT (History)
9 users (show)

See Also:

Patch (5.30 KB, patch)
2012-09-12 14:17 PDT, Rick Byers
no flags Details | Formatted Diff | Diff
Fix ChangeLog copy-paste error (5.28 KB, patch)
2012-09-12 15:02 PDT, Rick Byers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Byers 2012-08-30 13:43:52 PDT
Once bug 93123 lands, and chromium is updated to stop using the old fields (deltaX, deltaY, boundingBox), we can remove them from WebGestureEvent.  This will shrink WebGestureEvent from 56 bytes to 32 bytes.
Comment 1 Rick Byers 2012-09-04 06:49:48 PDT
The part this change depends on has been split into bug 95573
Comment 2 Rick Byers 2012-09-12 14:17:37 PDT
Created attachment 163693 [details]
Comment 3 Rick Byers 2012-09-12 14:18:39 PDT
Ok, ready to take this last big step (so nobody can add any new code to write to these obsolete fields).  Can someone review please - abarth?
Comment 4 WebKit Review Bot 2012-09-12 14:20:04 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 Alexandre Elias 2012-09-12 14:25:31 PDT
LGTM, thanks.  abarth can give the r+.
Comment 6 Adam Barth 2012-09-12 14:29:13 PDT
Comment on attachment 163693 [details]

Yay!  Thanks.
Comment 7 WebKit Review Bot 2012-09-12 14:50:32 PDT
Comment on attachment 163693 [details]

Rejecting attachment 163693 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 154697 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 154697.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13821920
Comment 8 Rick Byers 2012-09-12 15:02:06 PDT
Created attachment 163708 [details]
Fix ChangeLog copy-paste error
Comment 9 Rick Byers 2012-09-12 15:03:06 PDT
Comment on attachment 163708 [details]
Fix ChangeLog copy-paste error

Darn, sorry - fixed duplicate 'Reviewed by NOBODY' line in ChangeLog, otherwise no changes.
Comment 10 WebKit Review Bot 2012-09-12 16:16:37 PDT
Comment on attachment 163708 [details]
Fix ChangeLog copy-paste error

Clearing flags on attachment: 163708

Committed r128378: <http://trac.webkit.org/changeset/128378>
Comment 11 WebKit Review Bot 2012-09-12 16:16:42 PDT
All reviewed patches have been landed.  Closing bug.