New fast/forms/number/number-interactive-validation-required.html introduced in https://trac.webkit.org/changeset/127564 fails on Qt WK2: --- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/forms/number/number-interactive-validation-required-expected.txt +++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/forms/number/number-interactive-validation-required-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS queryValues["test"] is "123456789" +FAIL queryValues["test"] should be 123456789. Was . PASS successfullyParsed is true TEST COMPLETE
I skipped it to paint the bot green - https://trac.webkit.org/changeset/127697 Please unskip it with the proper fix.
The test number-interactive-validation-required.html assumes interactive validation is enabled by port. If Qt port doesn't enable that, skipping this test is safe.
We need to enabled interactive form validation setting in WebKitTestRunner (as we are doing in DumpRenderTree already). I'll upload a patch soon.
Created attachment 163045 [details] Patch
Comment on attachment 163045 [details] Patch Rejecting attachment 163045 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: .. Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Failed to merge in the changes. Patch failed at 0001 Unreviewed GTK gardening. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13804437
Created attachment 163056 [details] Patch for landing Rebased on master. Could someone please cq+ ?
Comment on attachment 163056 [details] Patch for landing Clearing flags on attachment: 163056 Committed r128030: <http://trac.webkit.org/changeset/128030>
All reviewed patches have been landed. Closing bug.
*** Bug 57455 has been marked as a duplicate of this bug. ***
*** Bug 57450 has been marked as a duplicate of this bug. ***
*** Bug 95041 has been marked as a duplicate of this bug. ***