Bug 95817 – [Tests] We should have interactive validation of required value for the "input" element

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

We should have following test cases for "required" attribute on submit:
  - No submission occurred when required values aren't presented
  - Submission occurred when required values are presented and submission data are expected values.

Created attachment 162166 [details]
Patch 1

Comment on attachment 162166 [details]
Patch 1

Could you review this patch?
Thanks in advance.

[Kent Tamura]

Comment on attachment 162166 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=162166&action=review

> LayoutTests/fast/forms/date/date-interactive-validation-required-expected.txt:1
> +Test interactive validation with required attribute

The test result doesn't contain enough information.
We should mention that the test checks if an empty required field prevents form submission and checks if a non-empty required field doesn't prevent form submission.

> LayoutTests/fast/forms/resources/common-interactive-validation-required.js:32
> +        testFailed('Focus should be on test element.');
> +        return;

Need to call finishJSTest().

> LayoutTests/fast/forms/resources/common-interactive-validation-required.js:38
> +    testFailed('The form was not submitted.');

Need to call finishJSTest().

> LayoutTests/fast/forms/resources/common-interactive-validation-required.js:39
> +    return;

"return" at the end of function makes no sense.

Created attachment 162176 [details]
Patch 2

Comment on attachment 162176 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Update test description in JavaScript.
* Add to call finishJSTest()
* Remove extra "return" at the end of  function.

[Kent Tamura]

Comment on attachment 162176 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=162176&action=review

> LayoutTests/fast/forms/resources/common-interactive-validation-required.js:17
> +        if (window.testRunner)
> +            testRunner.notifyDone();

notifyDone() isn't needed.  finishJSTest() below does it.

Created attachment 162181 [details]
Patch 3

Comment on attachment 162181 [details]
Patch 3

Clearing flags on attachment: 162181

Committed r127564: <http://trac.webkit.org/changeset/127564>

All reviewed patches have been landed.  Closing bug.

If port doesn't enable interactive validation, please skip these tests.