Source/WebKit2/UIProcess/API/efl/EflViewportHandler.h:44:70: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’ Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp:64:23: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’
(In reply to comment #0) > Source/WebKit2/UIProcess/API/efl/EflViewportHandler.h:44:70: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’ > Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp:64:23: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’ BUG 95408 will fix these compile errors.
Created attachment 161611 [details] patch
Comment on attachment 161611 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=161611&action=review BTW, > Source/WebKit2/CMakeLists.txt:576 > +IF (WTF_USE_3D_GRAPHICS) CMakeLists.txt will may be used by other ports. So, I'm not sure if we can add this patch to CMakeList.txt. I think it would be good to move this to PlatformEfl.cmake for EFL port only. > Source/WebKit2/ChangeLog:10 > + * CMakeLists.txt: fatal error: ShaderLang.h: No such file or directory I think you have to mention what is modified in this file, not just build error.
BUG 95173 attempts to include ANGLE directory. I will rebase my patch after BUG 95173 landing.
Comment on attachment 161611 [details] patch Ok, I clear r? and cq? from attachment 161611 [details] so that this bug does not appear in http://webkit.org/pending-review.
(In reply to comment #5) > (From update of attachment 161611 [details]) > Ok, I clear r? and cq? from attachment 161611 [details] [details] so that this bug does not appear in http://webkit.org/pending-review. Thanks, I forgot asking it. :-)
Anything else that needs to be fixed before closing this bug?
(In reply to comment #7) > Anything else that needs to be fixed before closing this bug? AFAIK, I have to do little more things. I am checking on this. :-)
Created attachment 163304 [details] patch
Comment on attachment 163304 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=163304&action=review > Source/WebKit2/ChangeLog:11 > + (ewk_view_accelerated_compositing_mode_enter):NULL used in arithmetic [-Wpointer-arith] Just warning message looks not so good. Please write this error more clear.
Created attachment 163309 [details] patch Done!
Comment on attachment 163309 [details] patch Clearing flags on attachment: 163309 Committed r128163: <http://trac.webkit.org/changeset/128163>
All reviewed patches have been landed. Closing bug.