Bug 95342 - [WK2][EFL] Fix compile warnings when enable tiled backing store
Summary: [WK2][EFL] Fix compile warnings when enable tiled backing store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on: 95173 95377 95408 95422
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-29 06:50 PDT by Kangil Han
Modified: 2012-09-11 03:06 PDT (History)
4 users (show)

See Also:


Attachments
patch (5.07 KB, patch)
2012-08-30 20:07 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
patch (4.04 KB, patch)
2012-09-11 01:54 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
patch (4.11 KB, patch)
2012-09-11 02:20 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-08-29 06:50:05 PDT
Source/WebKit2/UIProcess/API/efl/EflViewportHandler.h:44:70: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’
Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp:64:23: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’
Comment 1 Kangil Han 2012-08-29 18:14:12 PDT
(In reply to comment #0)
> Source/WebKit2/UIProcess/API/efl/EflViewportHandler.h:44:70: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’
> Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp:64:23: error: ‘class WebKit::PageClientImpl’ has no member named ‘page’

BUG 95408 will fix these compile errors.
Comment 2 Kangil Han 2012-08-30 20:07:56 PDT
Created attachment 161611 [details]
patch
Comment 3 Gyuyoung Kim 2012-08-31 01:22:08 PDT
Comment on attachment 161611 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161611&action=review

BTW,

> Source/WebKit2/CMakeLists.txt:576
> +IF (WTF_USE_3D_GRAPHICS)

CMakeLists.txt will may be used by other ports. So, I'm not sure if we can add this patch to CMakeList.txt. I think it would be good to move this to PlatformEfl.cmake for EFL port only.

> Source/WebKit2/ChangeLog:10
> +        * CMakeLists.txt: fatal error: ShaderLang.h: No such file or directory

I think you have to mention what is modified in this file, not just build error.
Comment 4 Kangil Han 2012-08-31 02:56:37 PDT
BUG 95173 attempts to include ANGLE directory.
I will rebase my patch after BUG 95173 landing.
Comment 5 Gyuyoung Kim 2012-08-31 03:05:46 PDT
Comment on attachment 161611 [details]
patch

Ok, I clear r? and cq? from attachment 161611 [details] so that this bug does not appear in http://webkit.org/pending-review.
Comment 6 Kangil Han 2012-08-31 04:51:45 PDT
(In reply to comment #5)
> (From update of attachment 161611 [details])
> Ok, I clear r? and cq? from attachment 161611 [details] [details] so that this bug does not appear in http://webkit.org/pending-review.

Thanks, I forgot asking it. :-)
Comment 7 Raphael Kubo da Costa (:rakuco) 2012-09-11 01:13:16 PDT
Anything else that needs to be fixed before closing this bug?
Comment 8 Kangil Han 2012-09-11 01:23:33 PDT
(In reply to comment #7)
> Anything else that needs to be fixed before closing this bug?

AFAIK, I have to do little more things.
I am checking on this. :-)
Comment 9 Kangil Han 2012-09-11 01:54:12 PDT
Created attachment 163304 [details]
patch
Comment 10 Gyuyoung Kim 2012-09-11 02:06:53 PDT
Comment on attachment 163304 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163304&action=review

> Source/WebKit2/ChangeLog:11
> +        (ewk_view_accelerated_compositing_mode_enter):NULL used in arithmetic [-Wpointer-arith]

Just warning message looks not so good. Please write this error more clear.
Comment 11 Kangil Han 2012-09-11 02:20:23 PDT
Created attachment 163309 [details]
patch

Done!
Comment 12 WebKit Review Bot 2012-09-11 03:06:35 PDT
Comment on attachment 163309 [details]
patch

Clearing flags on attachment: 163309

Committed r128163: <http://trac.webkit.org/changeset/128163>
Comment 13 WebKit Review Bot 2012-09-11 03:06:40 PDT
All reviewed patches have been landed.  Closing bug.