Bug 95408 - [EFL][WK2] Replace PageClientImpl with ewk view in constructor of EflViewportHandler.
Summary: [EFL][WK2] Replace PageClientImpl with ewk view in constructor of EflViewport...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 95342
  Show dependency treegraph
 
Reported: 2012-08-29 17:32 PDT by Kangil Han
Modified: 2012-08-29 22:45 PDT (History)
4 users (show)

See Also:


Attachments
patch (4.61 KB, patch)
2012-08-29 18:12 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
patch (4.64 KB, patch)
2012-08-29 21:10 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-08-29 17:32:21 PDT
It could be replaced by ewk view.
Comment 1 Kangil Han 2012-08-29 18:12:26 PDT
Created attachment 161380 [details]
patch
Comment 2 Ryuan Choi 2012-08-29 19:52:38 PDT
Comment on attachment 161380 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161380&action=review

> Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp:-43
> -    ASSERT(m_pageClientImpl);

Good to me.

As a nit, we can check m_viewWidget instead of m_pageClientImpl.
Comment 3 Kangil Han 2012-08-29 21:10:36 PDT
Created attachment 161394 [details]
patch

Done!
Comment 4 Gyuyoung Kim 2012-08-29 21:21:13 PDT
Comment on attachment 161394 [details]
patch

LGTM.
Comment 5 WebKit Review Bot 2012-08-29 22:45:13 PDT
Comment on attachment 161394 [details]
patch

Clearing flags on attachment: 161394

Committed r127102: <http://trac.webkit.org/changeset/127102>
Comment 6 WebKit Review Bot 2012-08-29 22:45:17 PDT
All reviewed patches have been landed.  Closing bug.