Bug 94483 - [EFL] Enable CSS Text Decoration by default
Summary: [EFL] Enable CSS Text Decoration by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks: 58491
  Show dependency treegraph
 
Reported: 2012-08-20 08:53 PDT by Thiago Marcos P. Santos
Modified: 2012-08-21 15:35 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.17 KB, patch)
2012-08-20 08:58 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-08-20 08:53:20 PDT
The feature is relatively new, but the EFL port has a big interest on it. IMO the best way of making this implementation mature is to add it to our continuous integration system (aka. bots) and make sure the tests are passing and keep the eyes opened for regressions.
Comment 1 Bruno Abinader (history only) 2012-08-20 08:58:18 PDT
(In reply to comment #0)
> The feature is relatively new, but the EFL port has a big interest on it. IMO the best way of making this implementation mature is to add it to our continuous integration system (aka. bots) and make sure the tests are passing and keep the eyes opened for regressions.

Awesome news, Thiago! I'll be taking care of EFL build on my CSS3 Text Decoration implementations. So far, in terms of implementation, only "wavy" text decoration style platform support (Cairo-specific bug 94110) and "-webkit-text-decoration-skip" (bug 92801). Other implementations are now pending review / commit-queue flags.
Comment 2 Thiago Marcos P. Santos 2012-08-20 08:58:44 PDT
Created attachment 159442 [details]
Patch
Comment 3 Thiago Marcos P. Santos 2012-08-20 09:01:23 PDT
Comment on attachment 159442 [details]
Patch

Removing cq?. Will give time to other developers from the community to comment on this bug.
Comment 4 Chris Dumez 2012-08-20 12:26:09 PDT
Looks good. Thanks Thiago.
Comment 5 Grzegorz Czajkowski 2012-08-21 00:11:27 PDT
It's good idea to enable this feature especially if we have Bruno's support.

BTW, did you check EWebLauncher/MiniBrowser behavior with this feature? Doesn't it cause any issues (for single and tiled backing stores in case of EWebLauncher)?
Comment 6 Thiago Marcos P. Santos 2012-08-21 04:52:33 PDT
(In reply to comment #5)
> It's good idea to enable this feature especially if we have Bruno's support.
> 
> BTW, did you check EWebLauncher/MiniBrowser behavior with this feature? Doesn't it cause any issues (for single and tiled backing stores in case of EWebLauncher)?

Tested MiniBrowser, EWebLauncher and ran a complete layout tests after enabling it locally. No regressions found.
Comment 7 WebKit Review Bot 2012-08-21 15:34:57 PDT
Comment on attachment 159442 [details]
Patch

Clearing flags on attachment: 159442

Committed r126197: <http://trac.webkit.org/changeset/126197>
Comment 8 WebKit Review Bot 2012-08-21 15:35:01 PDT
All reviewed patches have been landed.  Closing bug.