Bug 93645 – [EFL][WK2] Add Skipped file for EFL WK2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

EFL WK2 needs a separate Skipped file located at LayoutTests/platform/efl-wk2/Skipped so that it will be possible to keep EFL WK2 bot green.

[Mikhail Pozdnyakov]

Created attachment 157697 [details]
patch

[Kenneth Rohde Christiansen]

Comment on attachment 157697 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157697&action=review

> LayoutTests/ChangeLog:6
> +        Uneviewed gardening.

Unreviewed

[Mikhail Pozdnyakov]

Created attachment 157701 [details]
patch v2

[Mikhail Pozdnyakov]

(In reply to comment #2)
> (From update of attachment 157697 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157697&action=review
> 
> > LayoutTests/ChangeLog:6
> > +        Uneviewed gardening.
> 
> Unreviewed

Ouch..

[WebKit Review Bot]

Comment on attachment 157701 [details]
patch v2

Clearing flags on attachment: 157701

Committed r125273: <http://trac.webkit.org/changeset/125273>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Why would we add a Skipped list? We have been trying to get rid of the one for WebKit1-EFL for several months now. Adding one for WebKit2-EFL really seems like a step backwards. Is there a technical reason not to use a TestExpectations file?

[Mikhail Pozdnyakov]

(In reply to comment #7)
> Why would we add a Skipped list? We have been trying to get rid of the one for WebKit1-EFL for several months now. Adding one for WebKit2-EFL really seems like a step backwards. Is there a technical reason not to use a TestExpectations file?

I have tried TestExpectations first and it did not work for me, then I noticed that neither mac nor GTK (which does not have Skipped list for WK1 at all) use TestExpectations for WK2. I understand that TestExpectations is better but we need first to provide a fix in scripts to make it work.

[Chris Dumez]

(In reply to comment #8)
> (In reply to comment #7)
> > Why would we add a Skipped list? We have been trying to get rid of the one for WebKit1-EFL for several months now. Adding one for WebKit2-EFL really seems like a step backwards. Is there a technical reason not to use a TestExpectations file?
> 
> I have tried TestExpectations first and it did not work for me, then I noticed that neither mac nor GTK (which does not have Skipped list for WK1 at all) use TestExpectations for WK2. I understand that TestExpectations is better but we need first to provide a fix in scripts to make it work.

Ok, thanks for the explanation. I will try to fix the scripts and use TestExpectations instead in Bug 93796. Qt port is using TestExpectations for WK2 so it is possible.