Bug 93228 – REGRESSION(r124729): It made 6 inspector tests fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Kristóf Kosztyó]

This patch made 6 inspector test to fail on Qt. 

--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/debugger-activation-crash2-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/debugger-activation-crash2-actual.txt 
@@ -1,12 +1,7 @@
+CONSOLE MESSAGE: line 462: Internal watchdog triggered at 20 seconds. Test timed out.
 Tests for a crash when paused at a breakpoint caused by inaccurate Activation records. Bug 57120
 
 Debugger was enabled.
 Script source was shown.
 Set timer for test function.
-Script execution paused.
-Call stack:
-    0)  (debugger-activation-crash2.html)
-    1) testFunction (debugger-activation-crash2.html)
-Script execution resumed.
-Debugger was disabled.



--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/debugger-set-breakpoint-regex-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/debugger-set-breakpoint-regex-actual.txt 
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 Tests Debugger.setBreakpointByUrl with isRegex set to true.
 
 Debugger was enabled.
@@ -10,9 +11,4 @@
 
 Running: testSetByRegex
 Set timer for test function.
-Script execution paused.
-Call stack:
-    0) testFunction (debugger-set-breakpoint-regex.html:9)
-Script execution resumed.
-Debugger was disabled.


--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/pause-in-internal-script-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/pause-in-internal-script-actual.txt 
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 Tests that internal scripts unknown to front-end are processed correctly when appear in debugger call frames. Bug 64995
 
 Debugger was enabled.
@@ -5,11 +6,4 @@
 Running: testSetBreakpoint
 Script source was shown.
 Set timer for test function.
-Script execution paused.
-Call stack:
-    0)  (pause-in-internal-script.html:14)
-    1) testFunction (pause-in-internal-script.html:12)
-Script execution resumed.
-Script execution paused.
-Debugger was disabled.



--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/script-formatter-breakpoints-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/script-formatter-breakpoints-actual.txt 
@@ -1,23 +1,7 @@
+FAIL: Timed out waiting for notifyDone to be called
 Tests the script formatting is working fine with breakpoints.
 
 Debugger was enabled.
 
 Running: testBreakpointsInOriginalAndFormattedSource
-Script execution paused.
-Breakpoint sidebar pane while paused in raw
 
-    script-formatter-breakpoints.html:11
-    var f=0;
-Script execution resumed.
-Script execution paused.
-Breakpoint sidebar pane while paused in pretty printed
-
-    script-formatter-breakpoints.html:18
-    var f = 0;
-Breakpoint sidebar pane while paused in raw
-
-    script-formatter-breakpoints.html:11
-    var f=0;
-Script execution resumed.
-Debugger was disabled.
-



--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/set-breakpoint-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/set-breakpoint-actual.txt 
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 Tests setting breakpoints.
 
 Debugger was enabled.
@@ -5,27 +6,4 @@
 Running: testSetBreakpoint
 Script source was shown.
 Set timer for test function.
-Script execution paused.
-Call stack:
-    0) testFunction (set-breakpoint.html:17)
 
-Dump breakpoint sidebar pane:
-
-    set-breakpoint.html:17
-    var x = Math.sqrt(10);
-
-Dump breakpoint sidebar pane:
-
-Script execution resumed.
-
-Running: testSetBreakpointOnTheLastLine
-Call stack:
-    0) oneLineTestFunction (set-breakpoint.html:7)
-
-Running: testSetBreakpointOnTheLastLine2
-Call stack:
-    0) oneLineTestFunction2 (set-breakpoint.html:11)
-
-Running: testSetBreakpointOnTheSameLine
-Debugger was disabled.
-



--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/watch-expressions-panel-switch-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/debugger/watch-expressions-panel-switch-actual.txt 
@@ -1,12 +1,8 @@
+FAIL: Timed out waiting for notifyDone to be called
 Tests debugger does not fail when stopped while a panel other than scripts was opened. Both valid and invalid expressions are added to watch expressions.
 
 Bug 70718
 Debugger was enabled.
 Script source was shown.
 Set timer for test function.
-Watch expressions updated.
-[expanded]  
-    window.document: HTMLDocument
-    windowa.document: ReferenceError: Can't find variable: windowa
-Debugger was disabled.

[Kristóf Kosztyó]

I skipped them in r124737 to make the bot green.

[Peter Wang]

Sorry, the "Script" panel seems disappeared recently, so I can't verify it manually. Can I use "run-webkit-tests --qt" directly to reproduce it?

[Csaba Osztrogonác]

It isn't Qt specific bug, these tests fail on Lion too.

[Peter Wang]

The patch for https://bugs.webkit.org/show_bug.cgi?id=93387 can also resolve the problem of QT porting.

[Kristóf Kosztyó]

Committed r125517: <http://trac.webkit.org/changeset/125517>