Debugger fails when there an invalid watch expression. To reproduce: 1) add invalid watch expression, e.g. "windowa.document" 2) set some breakpoint and trigger stop on it. You will not see any call frames and execution line will not be shown.
Created attachment 112189 [details] Patch
Comment on attachment 112189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112189&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:576 > + if (WebInspector.panels.scripts.paused && WebInspector.panels.scripts.isCallFrameSelected()) { I'd suggest that we maintain the following invariant: whenever paused === true, there is a call frame selected. > Source/WebCore/inspector/front-end/ScriptsPanel.js:478 > + if (selectedCallFrame) Let's fail in case there is not selected callframe.
Created attachment 112333 [details] Patch
As discussed offline, this patch fixes the problem itself and overall watch expressions logic will be fixed in the separate patch.
Comment on attachment 112333 [details] Patch Clearing flags on attachment: 112333 Committed r98346: <http://trac.webkit.org/changeset/98346>
All reviewed patches have been landed. Closing bug.
The test added by this patch is timing out on Snow Leopard: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r98350%20(34191)/inspector/debugger/watch-expressions-panel-switch-pretty-diff.html
It's also failing on Qt: http://build.webkit.org/results/Qt%20Linux%20Release/r98353%20(38935)/results.html
Filed https://bugs.webkit.org/show_bug.cgi?id=70831 for test failures
Reopening since it was rolled out.
Created attachment 112470 [details] Patch
Comment on attachment 112470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112470&action=review > LayoutTests/inspector/debugger/watch-expressions-panel-switch.html:16 > + InspectorTest.startDebuggerTest(step1); Yep.
Committed r98454: <http://trac.webkit.org/changeset/98454>