Bug 92081 - [Tests] Re-factor some tests in fast/forms/number for sharing with other input types
Summary: [Tests] Re-factor some tests in fast/forms/number for sharing with other inpu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 92083
Blocks: 91805
  Show dependency tree / graph
 
Reported: 2012-07-24 01:38 PDT by yosin
Modified: 2012-07-24 18:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (8.78 KB, patch)
2012-07-24 03:01 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (9.06 KB, patch)
2012-07-24 03:05 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (9.27 KB, patch)
2012-07-24 18:39 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-07-24 01:38:03 PDT 
Following two tests are effective for other input types:
1. number-change-type-on-focus.html
  Change input type during event handling
2. number-crash.html
  Get rid renderer object during event handling
Comment 1 yosin 2012-07-24 03:01:20 PDT 
Created attachment 154002 [details]
Patch 1
Comment 2 yosin 2012-07-24 03:05:46 PDT 
Created attachment 154003 [details]
Patch 2
Comment 3 yosin 2012-07-24 03:06:48 PDT 
Comment on attachment 154003 [details]
Patch 2

Could you review this patch?
Thanks in advance.
Comment 4 Kent Tamura 2012-07-24 18:05:52 PDT 
Comment on attachment 154003 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=154003&action=review

> LayoutTests/fast/forms/resources/common-change-type-on-focus.js:3
> +function doTest(sampleId)

should have more descriptive function name.

> LayoutTests/fast/forms/resources/common-losing-renderer-on-click.js:1
> +function test()

ditto.
Comment 5 yosin 2012-07-24 18:39:07 PDT 
Created attachment 154215 [details]
Patch 3
Comment 6 Kent Tamura 2012-07-24 18:41:01 PDT 
Comment on attachment 154215 [details]
Patch 3

ok
Comment 7 yosin 2012-07-24 18:45:32 PDT 
Comment on attachment 154215 [details]
Patch 3

Clearing flags on attachment: 154215

Committed r123563: <http://trac.webkit.org/changeset/123563>
Comment 8 yosin 2012-07-24 18:45:36 PDT 
All reviewed patches have been landed.  Closing bug.