Bug 92083 – [Tests] Copy fast/forms/number/number-change-type-on-focus.html and number-losing-renderer-on-click.html to fast/forms/resources

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

I would like to re-factor fast/forms/number/number-change-type-on-focus.html and number-crash.html to share JavaScript code with other input types.

This bug is preparation of this re-factoring and copy two HTML files into JavaScript code directory (fast/forms/resources) as JavaScript code files.

Created attachment 153992 [details]
Patch 1

Comment on attachment 153992 [details]
Patch 1

Could you review this patch?
Thanks in advance.

The diff is result of "svn copy" command lines. They are copy of original files.

[Kent Tamura]

Comment on attachment 153992 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=153992&action=review

> LayoutTests/ChangeLog:11
> +          - number-crash.html -> common-crash.js

I don't think common-crash.js is an appropriate name.  common-losing-renderer-on-click.js?

The test "number-crash.html" was renamed to "number-losing-renderer-on-click.html"

Created attachment 154000 [details]
Patch 2

Comment on attachment 154000 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Changed for file name renaming number-crash.html => number-losing-renderer-on-click.html

[Kent Tamura]

Comment on attachment 154000 [details]
Patch 2

ok

* Change set is OK
 http://trac.webkit.org/changeset/123448
* Entries is OK.
 http://trac.webkit.org/log/trunk/LayoutTests/fast/forms/resources/common-change-type-on-focus.js?rev=123448