Bug 92083 - [Tests] Copy fast/forms/number/number-change-type-on-focus.html and number-losing-renderer-on-click.html to fast/forms/resources
Summary: [Tests] Copy fast/forms/number/number-change-type-on-focus.html and number-lo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 92085
Blocks: 92081
  Show dependency tree / graph
 
Reported: 2012-07-24 01:51 PDT by yosin
Modified: 2012-07-24 02:52 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (4.13 KB, patch)
2012-07-24 02:07 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (4.36 KB, patch)
2012-07-24 02:45 PDT, yosin 		tkent: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-07-24 01:51:45 PDT 
I would like to re-factor fast/forms/number/number-change-type-on-focus.html and number-crash.html to share JavaScript code with other input types.

This bug is preparation of this re-factoring and copy two HTML files into JavaScript code directory (fast/forms/resources) as JavaScript code files.
Comment 1 yosin 2012-07-24 02:07:26 PDT 
Created attachment 153992 [details]
Patch 1
Comment 2 yosin 2012-07-24 02:08:35 PDT 
Comment on attachment 153992 [details]
Patch 1

Could you review this patch?
Thanks in advance.

The diff is result of "svn copy" command lines. They are copy of original files.
Comment 3 Kent Tamura 2012-07-24 02:12:38 PDT 
Comment on attachment 153992 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=153992&action=review

> LayoutTests/ChangeLog:11
> +          - number-crash.html -> common-crash.js

I don't think common-crash.js is an appropriate name.  common-losing-renderer-on-click.js?
Comment 4 yosin 2012-07-24 02:42:35 PDT 
The test "number-crash.html" was renamed to "number-losing-renderer-on-click.html"
Comment 5 yosin 2012-07-24 02:45:27 PDT 
Created attachment 154000 [details]
Patch 2
Comment 6 yosin 2012-07-24 02:46:37 PDT 
Comment on attachment 154000 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Changed for file name renaming number-crash.html => number-losing-renderer-on-click.html
Comment 7 Kent Tamura 2012-07-24 02:49:48 PDT 
Comment on attachment 154000 [details]
Patch 2

ok