Now that our Ewk structures have constructors, it makes sense to define destructors as well.
Created attachment 152456 [details] Patch
Comment on attachment 152456 [details] Patch Looks reasonable. Let me r+ it after informal reviews from EFL folks.
Comment on attachment 152456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152456&action=review > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:62 > + { Don't you need to add ASSERT(!__ref); here as well ?
Comment on attachment 152456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152456&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:62 >> + { > > Don't you need to add ASSERT(!__ref); here as well ? No, _Ewk_Navigation_Policy_Decision is not ref counted. There is no __ref member in the struct.
(In reply to comment #3) > (From update of attachment 152456 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152456&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:62 > > + { > > Don't you need to add ASSERT(!__ref); here as well ? I'll make Ewk_Navigation_Policy_Decision ref counted in Bug 91343 though so I'll add the ASSERT there.
Created attachment 152460 [details] Patch Move the default policy decision code to the Ewk_Navigation_Policy_Decision destructor as well.
Comment on attachment 152460 [details] Patch Looks OK to me.
Comment on attachment 152460 [details] Patch LGTM too.
Comment on attachment 152460 [details] Patch Thanks for reviews. Looks OK to me.
Comment on attachment 152460 [details] Patch Clearing flags on attachment: 152460 Committed r122697: <http://trac.webkit.org/changeset/122697>
All reviewed patches have been landed. Closing bug.