Bug 91343 - [EFL][WK2] Make Ewk_Navigation_Policy_Decision ref counted
Summary: [EFL][WK2] Make Ewk_Navigation_Policy_Decision ref counted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency tree / graph
 
Reported: 2012-07-15 04:55 PDT by Chris Dumez
Modified: 2012-07-16 11:21 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.53 KB, patch)
2012-07-15 05:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.16 KB, patch)
2012-07-16 10:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-15 04:55:32 PDT 
We need to make Ewk_Navigation_Policy_Decision ref counted so that the client can make navigation policy decisions asynchronously.
i.e. the client can catch the "policy,decision,navigation" signal on the Ewk_View and call ewk_navigation_policy_decision_ref() on the Ewk_Navigation_Policy_Decision object to increase its refcount and make the decision later.
Comment 1 Chris Dumez 2012-07-15 05:00:44 PDT 
Created attachment 152459 [details]
Patch
Comment 2 Gyuyoung Kim 2012-07-16 00:35:06 PDT 
Comment on attachment 152459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152459&action=review

It looks there is no critical problem in this patch. Informal rs+ on my side.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:39
> + *   #Ewk_Navigation_Policy_Decision object using ewk_navigation_policy_decision_ref().

I think is it better to adhere indentation for comment. But, existing comments are similar to this.
Comment 3 Chris Dumez 2012-07-16 10:42:00 PDT 
Created attachment 152561 [details]
Patch

Rebase on master.
Comment 4 WebKit Review Bot 2012-07-16 11:21:37 PDT 
Comment on attachment 152561 [details]
Patch

Clearing flags on attachment: 152561

Committed r122742: <http://trac.webkit.org/changeset/122742>
Comment 5 WebKit Review Bot 2012-07-16 11:21:43 PDT 
All reviewed patches have been landed.  Closing bug.