Bug 90935 - Add parallel image decoders
Summary: Add parallel image decoders
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on: 93590 90443 90755 90757 90869 93174
Blocks: 90375 91203
  Show dependency treegraph
 
Reported: 2012-07-10 21:41 PDT by Kwang Yul Seo
Modified: 2014-02-05 10:58 PST (History)
3 users (show)

See Also:


Attachments
Patch (90.64 KB, patch)
2012-07-10 22:37 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (90.81 KB, patch)
2012-07-11 22:53 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (18.67 KB, patch)
2012-07-11 22:59 PDT, Kwonjin Jeong
no flags Details | Formatted Diff | Diff
Patch (90.76 KB, patch)
2012-07-17 16:26 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (90.75 KB, patch)
2012-07-17 18:00 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (93.86 KB, patch)
2012-07-19 04:04 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (93.86 KB, patch)
2012-07-19 04:06 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (93.85 KB, patch)
2012-07-19 04:11 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (93.85 KB, patch)
2012-07-25 18:16 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (93.89 KB, patch)
2012-07-25 18:21 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (93.59 KB, patch)
2012-07-27 00:55 PDT, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-07-10 21:41:53 PDT
Refer to the following design document for detailed explanation:

https://docs.google.com/document/pub?id=12gf7MhNHfupeR3GdRF-h2Vzg86viCbwXq8_JByHKlg0
Comment 1 Kwang Yul Seo 2012-07-10 22:37:22 PDT
Created attachment 151601 [details]
Patch
Comment 2 Dongseong Hwang 2012-07-11 01:15:05 PDT
This patch makes ImageElement and SVGImageElement be able to decode a image using parallel image decoder.

We will summit another patch that the background, mask and border image of CSS box model can use parallel image decoder soon.
Comment 3 Kwang Yul Seo 2012-07-11 22:53:11 PDT
Created attachment 151864 [details]
Patch
Comment 4 Kwonjin Jeong 2012-07-11 22:59:02 PDT
Created attachment 151865 [details]
Patch
Comment 5 Kwonjin Jeong 2012-07-11 23:02:53 PDT
(In reply to comment #4)
> Created an attachment (id=151865) [details]
> Patch

Oops. I am sorry this patch belongs to Bug 90869!
Comment 6 Kwang Yul Seo 2012-07-13 01:48:25 PDT
(In reply to comment #2)
> This patch makes ImageElement and SVGImageElement be able to decode a image using parallel image decoder.
> 
> We will summit another patch that the background, mask and border image of CSS box model can use parallel image decoder soon.

We uploaded the patch in Bug 91203
Comment 7 Gyuyoung Kim 2012-07-17 03:28:52 PDT
Comment on attachment 151864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151864&action=review

> Source/WebCore/CMakeLists.txt:1203
> +    platform/graphics/ParallelImageDecoder.cpp

Nit : Please add file by alphabetical order.

> Source/WebCore/Target.pri:1106
> +    platform/graphics/RetainedModeBitmapImage.cpp \

ditto.

> Source/WebCore/Target.pri:2246
> +    platform/graphics/RetainedModeBitmapImage.h \

ditto.
Comment 8 Kwang Yul Seo 2012-07-17 16:26:24 PDT
Created attachment 152868 [details]
Patch
Comment 9 Kwang Yul Seo 2012-07-17 16:26:59 PDT
(In reply to comment #7)
> (From update of attachment 151864 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151864&action=review
> 
> > Source/WebCore/CMakeLists.txt:1203
> > +    platform/graphics/ParallelImageDecoder.cpp
> 
> Nit : Please add file by alphabetical order.
> 
> > Source/WebCore/Target.pri:1106
> > +    platform/graphics/RetainedModeBitmapImage.cpp \
> 
> ditto.
> 
> > Source/WebCore/Target.pri:2246
> > +    platform/graphics/RetainedModeBitmapImage.h \
> 
> ditto.

Thanks. Done!
Comment 10 Kwang Yul Seo 2012-07-17 18:00:39 PDT
Created attachment 152891 [details]
Patch
Comment 11 Kwang Yul Seo 2012-07-17 18:01:31 PDT
(In reply to comment #10)
> Created an attachment (id=152891) [details]
> Patch

Changed the threshold to 300 * 300.
Comment 12 Dongseong Hwang 2012-07-19 04:04:42 PDT
Created attachment 153219 [details]
Patch
Comment 13 Dongseong Hwang 2012-07-19 04:06:57 PDT
Created attachment 153220 [details]
Patch
Comment 14 Dongseong Hwang 2012-07-19 04:11:43 PDT
Created attachment 153221 [details]
Patch
Comment 15 Dongseong Hwang 2012-07-19 04:14:36 PDT
(In reply to comment #14)
> Created an attachment (id=153221) [details]
> Patch

Amended RenderLayerBacking in order to not decode the image repeatedly.

After sending the decoding complete image to each platform accelerated compositing tree, RenderLayerBacking should not decode again.
Comment 16 Dongseong Hwang 2012-07-25 18:16:54 PDT
Created attachment 154506 [details]
Patch
Comment 17 Dongseong Hwang 2012-07-25 18:21:38 PDT
Created attachment 154507 [details]
Patch
Comment 18 Dongseong Hwang 2012-07-25 18:22:43 PDT
(In reply to comment #17)
> Created an attachment (id=154507) [details]
> Patch

Rebased to the latest revision.
Comment 19 Dongseong Hwang 2012-07-27 00:55:12 PDT
Created attachment 154871 [details]
Patch
Comment 20 Dongseong Hwang 2012-07-27 00:57:00 PDT
(In reply to comment #19)
> Created an attachment (id=154871) [details]
> Patch

Fix the bug to cause crash.
Comment 21 Anders Carlsson 2014-02-05 10:58:46 PST
Comment on attachment 154871 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.